From 513f2ad72ebbe585700b1b4a24372b2e76871dc0 Mon Sep 17 00:00:00 2001 From: mcilwain Date: Thu, 28 Jun 2018 07:34:45 -0700 Subject: [PATCH] Export Weimin as author of commits to GitHub Also adds Guy to list of CONTRIBUTORS and removes Xooglers (who definitely won't be contributing more code). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=202476218 --- CONTRIBUTORS | 2 ++ .../registry/dns/writer/clouddns/CloudDnsWriterModule.java | 1 + .../registry/tools/CreateOrUpdatePremiumListCommand.java | 6 +++--- java/google/registry/ui/server/registrar/BUILD | 1 - javatests/google/registry/ui/server/registrar/BUILD | 1 - 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTORS b/CONTRIBUTORS index c44e6ddc4..c61434fa9 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -30,3 +30,5 @@ Jordyn Buchanan Wolfgang Meyers Hans Ridder Justin Graham +Guy Bensky +Weimin Yu diff --git a/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java b/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java index 11e8a2f90..f73d085c2 100644 --- a/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java +++ b/java/google/registry/dns/writer/clouddns/CloudDnsWriterModule.java @@ -59,6 +59,7 @@ public abstract class CloudDnsWriterModule { @IntoMap @StringKey(CloudDnsWriter.NAME) abstract DnsWriter provideWriter(CloudDnsWriter writer); + @Provides @IntoSet @Named("dnsWriterNames") diff --git a/java/google/registry/tools/CreateOrUpdatePremiumListCommand.java b/java/google/registry/tools/CreateOrUpdatePremiumListCommand.java index 44d8b3b4a..051990ebd 100644 --- a/java/google/registry/tools/CreateOrUpdatePremiumListCommand.java +++ b/java/google/registry/tools/CreateOrUpdatePremiumListCommand.java @@ -110,12 +110,12 @@ abstract class CreateOrUpdatePremiumListCommand extends ConfirmingCommand return extractServerResponse(response); } - // TODO(tjb): refactor this behavior into a better general-purpose + // TODO(user): refactor this behavior into a better general-purpose // response validation that can be re-used across the new client/server commands. String extractServerResponse(String response) { Map responseMap = toMap(JSONValue.parse(stripJsonPrefix(response))); - // TODO(tjb): consider using jart's FormField Framework. + // TODO(user): consider using jart's FormField Framework. // See: j/c/g/d/r/ui/server/RegistrarFormFields.java String status = (String) responseMap.get("status"); Verify.verify(!status.equals("error"), "Server error: %s", responseMap.get("error")); @@ -128,7 +128,7 @@ abstract class CreateOrUpdatePremiumListCommand extends ConfirmingCommand return (Map) obj; } - // TODO(tjb): figure out better place to put this method to make it re-usable + // TODO(user): figure out better place to put this method to make it re-usable static String stripJsonPrefix(String json) { Verify.verify(json.startsWith(JSON_SAFETY_PREFIX)); return json.substring(JSON_SAFETY_PREFIX.length()); diff --git a/java/google/registry/ui/server/registrar/BUILD b/java/google/registry/ui/server/registrar/BUILD index c462fc4f9..1dedf981e 100644 --- a/java/google/registry/ui/server/registrar/BUILD +++ b/java/google/registry/ui/server/registrar/BUILD @@ -26,7 +26,6 @@ java_library( "//java/google/registry/ui/soy/registrar:soy_java_wrappers", "//java/google/registry/util", "//third_party/objectify:objectify-v4_1", - "@com_braintreepayments_gateway_braintree_java", "@com_google_appengine_api_1_0_sdk", "@com_google_code_findbugs_jsr305", "@com_google_dagger", diff --git a/javatests/google/registry/ui/server/registrar/BUILD b/javatests/google/registry/ui/server/registrar/BUILD index 088eeef3e..62d41d283 100644 --- a/javatests/google/registry/ui/server/registrar/BUILD +++ b/javatests/google/registry/ui/server/registrar/BUILD @@ -25,7 +25,6 @@ java_library( "//javatests/google/registry/security", "//javatests/google/registry/testing", "//third_party/objectify:objectify-v4_1", - "@com_braintreepayments_gateway_braintree_java", "@com_google_appengine_api_1_0_sdk", "@com_google_flogger", "@com_google_flogger_system_backend",