From 5658fbe8bd9da72b519c69928c1bc5c535726d00 Mon Sep 17 00:00:00 2001 From: Lai Jiang Date: Thu, 29 Jun 2023 16:48:44 -0400 Subject: [PATCH] Remove stale references to App Engine in CloudTasksUtils (#2064) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This change is [Reviewable](https://reviewable.io/reviews/google/nomulus/2064) --- .../registry/batch/CloudTasksUtils.java | 20 ++++--------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/core/src/main/java/google/registry/batch/CloudTasksUtils.java b/core/src/main/java/google/registry/batch/CloudTasksUtils.java index cf9e23439..21efc43cd 100644 --- a/core/src/main/java/google/registry/batch/CloudTasksUtils.java +++ b/core/src/main/java/google/registry/batch/CloudTasksUtils.java @@ -92,10 +92,7 @@ public class CloudTasksUtils implements Serializable { return retrier.callWithRetry( () -> { logger.atInfo().log( - "Enqueuing queue='%s' endpoint='%s' service='%s'", - queue, - task.getAppEngineHttpRequest().getRelativeUri(), - task.getAppEngineHttpRequest().getAppEngineRouting().getService()); + "Enqueuing queue='%s' endpoint='%s'", queue, task.getHttpRequest().getUrl()); return client.enqueue(projectId, locationId, queue, task); }, ApiException.class); @@ -159,10 +156,7 @@ public class CloudTasksUtils implements Serializable { * * @param path the relative URI (staring with a slash and ending without one). * @param method the HTTP method to be used for the request, only GET and POST are supported. - * @param service the App Engine service to route the request to. Note that with App Engine Task - * Queue API if no service is specified, the service which enqueues the task will be used to - * process the task. Cloud Tasks API does not support this feature so the service will always - * needs to be explicitly specified. + * @param service the App Engine service to route the request to. * @param params a multimap of URL query parameters. Duplicate keys are saved as is, and it is up * to the server to process the duplicate keys. * @return the enqueued task. @@ -198,10 +192,7 @@ public class CloudTasksUtils implements Serializable { * * @param path the relative URI (staring with a slash and ending without one). * @param method the HTTP method to be used for the request, only GET and POST are supported. - * @param service the App Engine service to route the request to. Note that with App Engine Task - * Queue API if no service is specified, the service which enqueues the task will be used to - * process the task. Cloud Tasks API does not support this feature so the service will always - * needs to be explicitly specified. + * @param service the App Engine service to route the request to. * @param params a multimap of URL query parameters. Duplicate keys are saved as is, and it is up * to the server to process the duplicate keys. * @param jitterSeconds the number of seconds that a task is randomly delayed up to. @@ -232,10 +223,7 @@ public class CloudTasksUtils implements Serializable { * * @param path the relative URI (staring with a slash and ending without one). * @param method the HTTP method to be used for the request, only GET and POST are supported. - * @param service the App Engine service to route the request to. Note that with App Engine Task - * Queue API if no service is specified, the service which enqueues the task will be used to - * process the task. Cloud Tasks API does not support this feature so the service will always - * needs to be explicitly specified. + * @param service the App Engine service to route the request to. * @param params a multimap of URL query parameters. Duplicate keys are saved as is, and it is up * to the server to process the duplicate keys. * @param delay the amount of time that a task needs to delayed for.