From 56c8bb0f2a76a715d0fbe76f82e1b82682ea3f61 Mon Sep 17 00:00:00 2001 From: mcilwain Date: Fri, 13 May 2016 15:12:00 -0700 Subject: [PATCH] Don't verify existence of autorenew poll messages There are several situations in which it is a valid system state for Keys to PollMessages on Domains to point to entities that don't exist, chief amongst them when a domain has been soft-deleted. We also can't simply null this out when soft-deleting domains, because there may be an un-acked recurrence meaning it can't be deleted. Given this, it doesn't make sense to check for entity existence here, as it is not a system invariant and cannot easily be made to be so. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=122300368 --- .../monitoring/whitebox/VerifyEntityIntegrityAction.java | 1 - 1 file changed, 1 deletion(-) diff --git a/java/google/registry/monitoring/whitebox/VerifyEntityIntegrityAction.java b/java/google/registry/monitoring/whitebox/VerifyEntityIntegrityAction.java index 722e9572e..65baf7681 100644 --- a/java/google/registry/monitoring/whitebox/VerifyEntityIntegrityAction.java +++ b/java/google/registry/monitoring/whitebox/VerifyEntityIntegrityAction.java @@ -274,7 +274,6 @@ public class VerifyEntityIntegrityAction implements Runnable { DomainResource domain = (DomainResource) domainBase; verifyExistence(key, domain.getApplication()); verifyExistence(key, domain.getAutorenewBillingEvent()); - verifyExistence(key, domain.getAutorenewPollMessage()); for (GracePeriod gracePeriod : domain.getGracePeriods()) { verifyExistence(key, gracePeriod.getOneTimeBillingEvent()); verifyExistence(key, gracePeriod.getRecurringBillingEvent());