Complete Joda-Time to java.time migration (#3039)

mirror of https://github.com/google/nomulus synced 2026-08-17 12:46:11 +00:00

This completes the exhaustive refactoring of foundational temporal types from Joda-Time to the native java.time API across the entire codebase.

- Replaced org.joda.time.DateTime, Instant, LocalDate, and Duration with java.time equivalents.
- Audited and updated Clock implementations (FakeClock, SystemClock). Added nowMillis(), nowDate(), and nowDateTime() to eliminate repetitive conversions and maintain parallel naming.
- Replaced ZonedDateTime with OffsetDateTime globally per go/avoid-zdt. OffsetDateTime is a better fit as we use a hardcoded ZoneOffset.UTC throughout the system, making geographical time zone rules (like daylight saving time) irrelevant and preventing serialization ambiguities. Added a presubmit check.
- Completely removed all transitional bridge methods from DateTimeUtils and deleted obsolete converters (e.g., DateTimeConverter).
- Updated testing infrastructure, Apache Beam pipelines, custom JCommander parameters, and networking modules to solely rely on java.time primitives.
- Retained the lone necessary org.joda.time.Instant usage in SafeBrowsingTransforms required by the Apache Beam API.
- Cleared Gradle lockfiles and removed the joda-time dependency entirely from the build configuration.

This commit is contained in:

Ben McIlwain

2026-05-13 16:07:19 +00:00

committed by

GitHub

parent b33c2f4874

commit 56fe588b56

218 changed files with 589 additions and 1390 deletions

									
										release/schema-verifier/verify_deployed_sql_schema.sh
									
		-1
	
												View File
												
				@@ -76,7 +76,6 @@ else

				  echo "Schema dumped."

				fi

				raw_diff=$(diff /schema/nomulus.golden.sql /schema/nomulus.actual.sql)

				# Clean up the raw_diff:

				# - Remove diff locations (e.g. "5,6c5,6): grep "^[<>]"