mirror of
https://github.com/google/nomulus
synced 2026-02-09 06:20:29 +00:00
Merge JUnitBackport's expectThrows into assertThrows
More information: https://github.com/junit-team/junit5/issues/531 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=187034408
This commit is contained in:
@@ -20,7 +20,7 @@ import static google.registry.model.ofy.ObjectifyService.ofy;
|
||||
import static google.registry.testing.DatastoreHelper.createTld;
|
||||
import static google.registry.testing.DatastoreHelper.loadRegistrar;
|
||||
import static google.registry.testing.DatastoreHelper.persistResource;
|
||||
import static google.registry.testing.JUnitBackports.expectThrows;
|
||||
import static google.registry.testing.JUnitBackports.assertThrows;
|
||||
import static org.joda.money.CurrencyUnit.USD;
|
||||
|
||||
import com.beust.jcommander.ParameterException;
|
||||
@@ -113,7 +113,7 @@ public class DeleteCreditCommandTest extends CommandTestCase<DeleteCreditCommand
|
||||
@Test
|
||||
public void testFailure_nonexistentParentRegistrar() throws Exception {
|
||||
IllegalArgumentException thrown =
|
||||
expectThrows(
|
||||
assertThrows(
|
||||
IllegalArgumentException.class,
|
||||
() -> runCommandForced("--registrar=FakeRegistrar", "--credit_id=" + creditAId));
|
||||
assertThat(thrown).hasMessageThat().contains("Registrar FakeRegistrar not found");
|
||||
@@ -123,7 +123,7 @@ public class DeleteCreditCommandTest extends CommandTestCase<DeleteCreditCommand
|
||||
public void testFailure_nonexistentCreditId() throws Exception {
|
||||
long badId = creditAId + creditBId + 1;
|
||||
NullPointerException thrown =
|
||||
expectThrows(
|
||||
assertThrows(
|
||||
NullPointerException.class,
|
||||
() -> runCommandForced("--registrar=TheRegistrar", "--credit_id=" + badId));
|
||||
assertThat(thrown).hasMessageThat().contains("ID " + badId);
|
||||
@@ -132,14 +132,14 @@ public class DeleteCreditCommandTest extends CommandTestCase<DeleteCreditCommand
|
||||
@Test
|
||||
public void testFailure_noRegistrar() throws Exception {
|
||||
ParameterException thrown =
|
||||
expectThrows(ParameterException.class, () -> runCommandForced("--credit_id=" + creditAId));
|
||||
assertThrows(ParameterException.class, () -> runCommandForced("--credit_id=" + creditAId));
|
||||
assertThat(thrown).hasMessageThat().contains("--registrar");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testFailure_noCreditId() throws Exception {
|
||||
ParameterException thrown =
|
||||
expectThrows(ParameterException.class, () -> runCommandForced("--registrar=TheRegistrar"));
|
||||
assertThrows(ParameterException.class, () -> runCommandForced("--registrar=TheRegistrar"));
|
||||
assertThat(thrown).hasMessageThat().contains("--credit_id");
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user