Remove more references to GAE (#2894)

These are old/pointless now that we've migrated to GKE. Note that this
doesn't update anything in the docs/ folder, as that's a much larger
project that should be done on its own.

core/src/test/java/google/registry/persistence/PersistenceModuleTest.java

@@ -72,7 +72,7 @@ class PersistenceModuleTest {
   }
 
   @Test
-  void appengineIsolation() {
+  void connectionIsolation() {
     assertThat(PersistenceModule.provideDefaultDatabaseConfigs().get(Environment.ISOLATION))
         .isEqualTo(TransactionIsolationLevel.TRANSACTION_SERIALIZABLE.name());
   }

core/src/test/java/google/registry/server/RegistryTestServerMain.java

@@ -52,12 +52,12 @@ public final class RegistryTestServerMain {
 
   @Parameter(
       names = "--login_email",
-      description = "Login email address for App Engine Local User Service.")
+      description = "Login email address for the local user service.")
   private String loginEmail = "Marla.Singer@crr.com";
 
   @Parameter(
       names = "--login_is_admin",
-      description = "Should logged in user be an admin for App Engine Local User Service.",
+      description = "Should logged in user be an admin for the local user service?",
       arity = 1)
   private boolean loginIsAdmin = true;
 
@@ -153,7 +153,6 @@ public final class RegistryTestServerMain {
       }
     } finally {
       server.stop();
-      // appEngine.tearDown();
     }
   }
 

core/src/test/java/google/registry/tools/server/ListDomainsActionTest.java

@@ -102,29 +102,6 @@ class ListDomainsActionTest extends ListActionTestCase {
         "^example2.foo$");
   }
 
-  @Test
-  void testRun_moreTldsThanMaxNumSubqueries() {
-    ListDomainsAction.maxNumSubqueries = 2;
-    createTlds("baa", "bab", "bac", "bad");
-    action.tlds = ImmutableSet.of("baa", "bab", "bac", "bad");
-    action.limit = 4;
-    persistActiveDomain("domain1.baa", DateTime.parse("2010-03-04T16:00:00Z"));
-    persistActiveDomain("domain2.bab", DateTime.parse("2009-03-04T16:00:00Z"));
-    persistActiveDomain("domain3.bac", DateTime.parse("2011-03-04T16:00:00Z"));
-    persistActiveDomain("domain4.bad", DateTime.parse("2010-06-04T16:00:00Z"));
-    persistActiveDomain("domain5.baa", DateTime.parse("2008-01-04T16:00:00Z"));
-    // Since the limit is 4, expect all but domain5.baa (the oldest), sorted by creationTime asc.
-    testRunSuccess(
-        action,
-        Optional.empty(),
-        Optional.empty(),
-        Optional.empty(),
-        "^domain2.bab$",
-        "^domain1.baa$",
-        "^domain4.bad$",
-        "^domain3.bac$");
-  }
-
   @Test
   void testRun_twoLinesWithIdOnlyNoHeader() {
     action.tlds = ImmutableSet.of("foo");

core/src/test/resources/google/registry/reporting/icann/attempted_adds_test.sql

@@ -19,7 +19,7 @@
   -- monthly GKE logs, searching for all create commands and associating
   -- them with their corresponding registrars.
 
-  -- Example log generated by FlowReporter in App Engine and GKE logs:
+  -- Example log generated by FlowReporter in GKE logs:
   --google.registry.flows.FlowReporter
   -- recordToLogs: FLOW-LOG-SIGNATURE-METADATA:
   --{"serverTrid":"oNwL2J2eRya7bh7c9oHIzg==-2360a","clientId":"ipmirror"

core/src/test/resources/google/registry/testing/logging.properties

@@ -3,6 +3,5 @@ handlers = java.util.logging.ConsoleHandler
 
 google.registry.level = FINE
 
-com.google.appengine.api.taskqueue.dev.level = WARNING
 com.google.apphosting.utils.config.level = WARNING
 org.quartz.level = WARNING