mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-23 08:24:19 +00:00
Code Issues Releases Wiki Activity

Improve Transaction gap processing (#1546)

Browse Source 
Skip multiple gaps in one pass and write the correct transaction id to
datastore.
This commit is contained in:
Michael Muller
2022-03-07 13:26:18 -05:00
committed by GitHub
parent 8db28b7e61
commit 71d13bab71
2 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/google/registry/model/replay/ReplicateToDatastoreAction.java
+8 -4
View File
@@ -127,12 +127,16 @@ public class ReplicateToDatastoreAction implements Runnable {
// Reload the last transaction id, which could possibly have changed.
LastSqlTransaction lastSqlTxn = LastSqlTransaction.load();
long nextTxnId = lastSqlTxn.getTransactionId() + 1;
if (nextTxnId < txnEntity.getId()) {
// Missing transaction id. This can happen normally. If a transaction gets
// rolled back, the sequence counter doesn't.
// Skip missing transactions. Missed transactions can happen normally. If a
// transaction gets rolled back, the sequence counter doesn't.
while (nextTxnId < txnEntity.getId()) {
logger.atWarning().log(
"Ignoring transaction %s, which does not exist.", nextTxnId);
} else if (nextTxnId > txnEntity.getId()) {
++nextTxnId;
}
if (nextTxnId > txnEntity.getId()) {
// We've already replayed this transaction. This shouldn't happen, as GAE cron
// is supposed to avoid overruns and this action shouldn't be executed from any
// other context, but it's not harmful as we can just ignore the transaction. Log