mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-10 01:56:11 +00:00
Code Issues Releases Wiki Activity

Improve Transaction gap processing (#1546)

Browse Source 
Skip multiple gaps in one pass and write the correct transaction id to
datastore.
This commit is contained in:
Michael Muller
2022-03-07 13:26:18 -05:00
committed by GitHub
parent 8db28b7e61
commit 71d13bab71
2 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java
+16 -12
View File
@@ -208,18 +208,20 @@ public class ReplicateToDatastoreActionTest {
TestObject foo = TestObject.create("foo");
insertInDb(foo);
// Fail during the transaction to delete it.
try {
jpaTm()
.transact(
() -> {
jpaTm().delete(foo.key());
// Explicitly save the transaction entity to force the id update.
jpaTm().insert(new TransactionEntity(new byte[] {1, 2, 3}));
throw new RuntimeException("fail!!!");
});
} catch (Exception e) {
logger.atInfo().log("Got expected exception.");
// Fail two transactions.
for (int i = 0; i < 2; ++i) {
try {
jpaTm()
.transact(
() -> {
jpaTm().delete(foo.key());
// Explicitly save the transaction entity to force the id update.
jpaTm().insert(new TransactionEntity(new byte[] {1, 2, 3}));
throw new RuntimeException("fail!!!");
});
} catch (Exception e) {
logger.atInfo().log("Got expected exception.");
}
}
TestObject bar = TestObject.create("bar");
@@ -230,11 +232,13 @@ public class ReplicateToDatastoreActionTest {
assertThat(txns).hasSize(2);
for (TransactionEntity txn : txns) {
assertThat(txn.getId()).isNotEqualTo(2);
assertThat(txn.getId()).isNotEqualTo(3);
applyTransaction(txn);
}
assertThat(ofyTm().transact(() -> ofyTm().loadByKey(foo.key()))).isEqualTo(foo);
assertThat(ofyTm().transact(() -> ofyTm().loadByKey(bar.key()))).isEqualTo(bar);
assertThat(ofyTm().transact(() -> LastSqlTransaction.load()).getTransactionId()).isEqualTo(4);
}
@Test