mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-06 08:07:03 +00:00
Code Issues Releases Wiki Activity

Do not escape WHOIS output

Browse Source 
Both WhoisAction and WhoisHttpAction set the HTTP response content type to "text/plain". There is no need to defensively escape the content. In fact, by escaping the content, it creates more problems down the line.

When used in a website, the response should be written into a DOM node by setting the textContent of the node, which automatically escapes the content.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=196743398
This commit is contained in:
jianglai
2018-05-17 21:52:35 -04:00
parent f1219120ea
commit 7388958df7
14 changed files with 26 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
javatests/google/registry/whois/NameserverWhoisResponseTest.java
+1 -1
View File
@@ -52,7 +52,7 @@ public class NameserverWhoisResponseTest {
@Before
public void setUp() {
persistNewRegistrar("example", "Example Registrar, Inc.", Registrar.Type.REAL, 8L);
persistNewRegistrar("example", "Hänsel & Gretel Registrar, Inc.", Registrar.Type.REAL, 8L);
persistResource(loadRegistrar("example").asBuilder().setUrl("http://my.fake.url").build());
createTld("tld");