mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-10-01 04:05:49 +00:00
Code Issues Releases Wiki Activity

Return RDAP 404 for domain w/nonexistent TLD (#2808)

Browse Source 
The TLD is technically valid but it doesn't exist for us -- we should
return 404 instead of 400 in these situations according to the RDAP
conformance docs
This commit is contained in:
gbrodman
2025-08-21 15:31:51 +00:00
committed by GitHub
parent 16859bb36a
commit 7e07fabf7e
4 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/test/java/google/registry/rdap/RdapDomainActionTest.java
+4 -13
View File
@@ -57,12 +57,7 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
/**
* Unit tests for {@link RdapDomainAction}.
*
* <p>TODO(b/26872828): The next time we do any work on RDAP, consider adding the APNIC RDAP
* conformance checker to the unit test suite.
*/
/** Unit tests for {@link RdapDomainAction}. */
class RdapDomainActionTest extends RdapActionBaseTestCase<RdapDomainAction> {
RdapDomainActionTest() {
@@ -260,15 +255,11 @@ class RdapDomainActionTest extends RdapActionBaseTestCase<RdapDomainAction> {
}
@Test
void testUnknownDomain_returns400() {
void testUnknownDomain_returns404() {
assertAboutJson()
.that(generateActualJson("missingdomain.com"))
.isEqualTo(
generateExpectedJsonError(
"missingdomain.com is not a valid domain name: Domain name is under tld com which"
+ " doesn't exist",
400));
assertThat(response.getStatus()).isEqualTo(400);
.isEqualTo(generateExpectedJsonError("missingdomain.com not found", 404));
assertThat(response.getStatus()).isEqualTo(404);
}
@Test