From 81b239c6b38ee67fee1cb577b256fe71e45230de Mon Sep 17 00:00:00 2001 From: Lai Jiang Date: Fri, 31 May 2024 09:34:50 -0400 Subject: [PATCH] Add a presubmit test to catch accidental usage of javax.servlet (#2461) --- config/presubmits.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/config/presubmits.py b/config/presubmits.py index 87b7916b9..5ab7e4aeb 100644 --- a/config/presubmits.py +++ b/config/presubmits.py @@ -202,6 +202,12 @@ PRESUBMITS = { {"/node_modules/"}, ): "Do not mock Response, use FakeResponse.", + PresubmitCheck( + r".*javax\.servlet\..*", + "java", + {"/node_modules/"}, + ): + "Do not use javax.servlet.* Use jakarta.servlet.* instead.", } # Note that this regex only works for one kind of Flyway file. If we want to