mirror of
https://github.com/google/nomulus
synced 2026-02-06 13:01:11 +00:00
Rationalize logging statements across codebase
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
This commit is contained in:
@@ -56,9 +56,9 @@ final class RegistrarLookupCommand implements WhoisCommand {
|
||||
}
|
||||
String normalized = normalizeRegistrarName(registrar.getRegistrarName());
|
||||
if (map.put(normalized, registrar) != null) {
|
||||
logger.warning(
|
||||
normalized
|
||||
+ " appeared as a normalized registrar name for more than one registrar");
|
||||
logger.warningfmt(
|
||||
"%s appeared as a normalized registrar name for more than one registrar.",
|
||||
normalized);
|
||||
}
|
||||
}
|
||||
// Use the normalized registrar name without its last word as a key, assuming there are
|
||||
|
||||
Reference in New Issue
Block a user