Rename various fields and classes after migration (#1784)

Also fixed a bug introduced in #1785 where identity checked were performed instead of equality. This resulted in two sets containing the same elements not being regarded as equal and subsequent DNS updated being unnecessarily enqueued.

core/src/main/resources/META-INF/persistence.xml

@@ -50,7 +50,7 @@
     <class>google.registry.model.domain.DomainHistory</class>
     <class>google.registry.model.domain.GracePeriod</class>
     <class>google.registry.model.domain.GracePeriod$GracePeriodHistory</class>
-    <class>google.registry.model.domain.secdns.DelegationSignerData</class>
+    <class>google.registry.model.domain.secdns.DomainDsData</class>
     <class>google.registry.model.domain.secdns.DomainDsDataHistory</class>
     <class>google.registry.model.domain.token.AllocationToken</class>
     <class>google.registry.model.domain.token.PackagePromotion</class>

core/src/main/resources/google/registry/beam/invoicing/sql/cloud_sql_billing_events.sql

@@ -26,7 +26,7 @@
 -- query's performance and consider switching to using a native query.
 
 SELECT b, r FROM BillingEvent b
-JOIN Registrar r ON b.clientId = r.clientIdentifier
+JOIN Registrar r ON b.clientId = r.registrarId
 JOIN Domain d ON b.domainRepoId = d.repoId
 JOIN Tld t ON t.tldStr = d.tld
 LEFT JOIN BillingCancellation c ON b.id = c.refOneTime

core/src/main/resources/google/registry/beam/spec11/sql/domain_name_infos.sql

@@ -19,14 +19,14 @@
   -- email address.
 
 SELECT
-  domain.fullyQualifiedDomainName AS domainName,
+  domain.domainName AS domainName,
   domain.__key__.name AS domainRepoId,
   registrar.clientId AS registrarId,
   COALESCE(registrar.emailAddress, '') AS registrarEmailAddress
 FROM ( (
     SELECT
       __key__,
-      fullyQualifiedDomainName,
+      domainName,
       currentSponsorClientId,
       creationTime
     FROM

core/src/main/resources/google/registry/reporting/spec11/soy/Spec11Email.soy

@@ -122,7 +122,7 @@
     </tr>
     {for $threat in $threats}
       <tr>
-        <td>{$threat['fullyQualifiedDomainName']}</td>
+        <td>{$threat['domainName']}</td>
         <td>{$threat['threatType']}</td>
       </tr>
     {/for}

core/src/main/resources/google/registry/ui/soy/registrar/WhoisSettings.soy

@@ -18,7 +18,7 @@
 
 /** Registrar whois settings page for view and edit. */
 {template .settings}
-  {@param clientIdentifier: string}
+  {@param registrarId: string}
   {@param? ianaIdentifier: int}
   {@param? icannReferralEmail: string}
   {@param readonly: bool}
@@ -40,8 +40,8 @@
     <table>
     {call registry.soy.forms.inputFieldRowWithValue}
       {param label: 'Name' /}
-      {param name: 'clientIdentifier' /}
-      {param value: $clientIdentifier /}
+      {param name: 'registrarId' /}
+      {param value: $registrarId /}
       {param readonly: true /}
     {/call}
     {call registry.soy.forms.inputFieldRowWithValue}