mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-05-28 18:50:35 +00:00
Code Issues Releases Wiki Activity

Simplify some of the RDAP Action classes

Browse Source 
Overriding getter methods to change values is a bit overkill when these values
are static (don't change based on internal state).

Just setting them in the base class' constructor is simpler.

Also, we can read the PATH of an Action based on the Annotation instead
returning it manually for each Action.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246135754
This commit is contained in:
guyben
2019-05-01 08:32:29 -07:00
committed by jianglai
parent 99aeedc598
commit 90c53152bf
21 changed files with 81 additions and 204 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
java/google/registry/rdap/RdapDomainSearchAction.java
View File

@@ -68,13 +68,11 @@ import org.joda.time.DateTime;
*/
@Action(
service = Action.Service.PUBAPI,
path = RdapDomainSearchAction.PATH,
path = "/rdap/domains",
method = {GET, HEAD},
auth = Auth.AUTH_PUBLIC)
public class RdapDomainSearchAction extends RdapSearchActionBase {
static final String PATH = "/rdap/domains";
static final int RESULT_SET_SIZE_SCALING_FACTOR = 30;
@NonFinalForTesting
@@ -85,21 +83,8 @@ public class RdapDomainSearchAction extends RdapSearchActionBase {
@Inject @Parameter("name") Optional<String> nameParam;
@Inject @Parameter("nsLdhName") Optional<String> nsLdhNameParam;
@Inject @Parameter("nsIp") Optional<String> nsIpParam;
@Inject public RdapDomainSearchAction() {}
@Override
public String getHumanReadableObjectTypeName() {
return "domain search";
}
@Override
public EndpointType getEndpointType() {
return EndpointType.DOMAINS;
}
@Override
public String getActionPath() {
return PATH;
@Inject public RdapDomainSearchAction() {
super("domain search", EndpointType.DOMAINS);
}
/**