mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-19 06:32:00 +00:00
Code Issues Releases Wiki Activity

Update the initial value for lastExpiringCertNotificationSentDate to START_OF_TIME (#1321)

Browse Source 
* Update the initial value for lastExpiringCertNotificationSentDate to START_OF_TIME
This commit is contained in:
Rachel Guan
2021-09-16 13:06:47 -04:00
committed by GitHub
parent 8d421e995e
commit 942584b880
2 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/test/java/google/registry/flows/certs/CertificateCheckerTest.java
+10 -7
View File
@@ -262,7 +262,7 @@ class CertificateCheckerTest {
DateTime.parse("2021-10-01T00:00:00Z"))
.cert();
String certificateStr = certificateChecker.serializeCertificate(certificate);
assertThat(certificateChecker.shouldReceiveExpiringNotification(null, certificateStr))
assertThat(certificateChecker.shouldReceiveExpiringNotification(START_OF_TIME, certificateStr))
.isFalse();
}
@@ -276,7 +276,7 @@ class CertificateCheckerTest {
DateTime.parse("2021-10-01T00:00:00Z"))
.cert();
String certificateStr = certificateChecker.serializeCertificate(certificate);
assertThat(certificateChecker.shouldReceiveExpiringNotification(null, certificateStr))
assertThat(certificateChecker.shouldReceiveExpiringNotification(START_OF_TIME, certificateStr))
.isFalse();
}
@@ -307,12 +307,14 @@ class CertificateCheckerTest {
DateTime.parse("2021-01-30T00:00:00Z"))
.cert();
String certificateStr = certificateChecker.serializeCertificate(certificate);
assertThat(certificateChecker.shouldReceiveExpiringNotification(null, certificateStr)).isTrue();
assertThat(certificateChecker.shouldReceiveExpiringNotification(START_OF_TIME, certificateStr))
.isTrue();
}
@Test
void test_shouldReceiveExpiringNotification_returnsFalse_between30and15_lastSentDateIsNotNull()
throws Exception {
void
test_shouldReceiveExpiringNotification_returnsFalse_between30and15_lastSentDateIsNotStartOfTime()
throws Exception {
fakeClock.setTo(DateTime.parse("2021-07-05T00:00:00Z"));
X509Certificate certificate =
SelfSignedCaCertificate.create(
@@ -329,7 +331,7 @@ class CertificateCheckerTest {
}
@Test
void test_shouldReceiveExpiringNotification_returnsTrue_between30and15_lastSentDateIsNull()
void test_shouldReceiveExpiringNotification_returnsTrue_between30and15_lastSentDateIsStartOfTime()
throws Exception {
fakeClock.setTo(DateTime.parse("2021-07-05T00:00:00Z"));
X509Certificate certificate =
@@ -339,7 +341,8 @@ class CertificateCheckerTest {
DateTime.parse("2021-07-25T00:00:00Z"))
.cert();
String certificateStr = certificateChecker.serializeCertificate(certificate);
assertThat(certificateChecker.shouldReceiveExpiringNotification(null, certificateStr)).isTrue();
assertThat(certificateChecker.shouldReceiveExpiringNotification(START_OF_TIME, certificateStr))
.isTrue();
}
@Test