mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-05-29 19:20:36 +00:00
Code Issues Releases Wiki Activity

Refactor some RDE import logic to be generic

Browse Source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136076610
This commit is contained in:
Wolfgang Meyers
2016-10-13 13:10:24 -07:00
committed by Ben McIlwain
parent 71d7a382f3
commit 94af94ddff
4 changed files with 51 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
java/google/registry/rde/RdeContactImportAction.java
View File

@@ -23,7 +23,6 @@ import com.google.appengine.tools.cloudstorage.GcsService;
import com.google.appengine.tools.cloudstorage.GcsServiceFactory;
import com.google.appengine.tools.cloudstorage.RetryParams;
import com.google.appengine.tools.mapreduce.Mapper;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Optional;
import com.google.common.collect.ImmutableList;
import google.registry.config.ConfigModule;
@@ -80,21 +79,15 @@ public class RdeContactImportAction implements Runnable {
/**
* Creates a new {@link RdeContactInput}
*
* <p>Should be overridden in a subclass for the purposes of unit testing.
*/
@VisibleForTesting
RdeContactInput createInput() {
private RdeContactInput createInput() {
return new RdeContactInput(mapShards, importBucketName, importFileName);
}
/**
* Creates a new {@link RdeContactImportMapper}
*
* <p>Should be overridden in a subclass for the purposes of unit testing.
*/
@VisibleForTesting
RdeContactImportMapper createMapper() {
private RdeContactImportMapper createMapper() {
return new RdeContactImportMapper(importBucketName);
}