From 96d3d88c2fe5ccb4a1c674d8a590eb2b75848468 Mon Sep 17 00:00:00 2001 From: sarahcaseybot Date: Fri, 26 Jul 2024 13:50:35 -0400 Subject: [PATCH] Remove TODOs assigned to sarahbot (#2508) --- .../main/java/google/registry/batch/DeleteProberDataAction.java | 2 +- .../java/google/registry/flows/domain/DomainCreateFlow.java | 1 - .../google/registry/model/domain/token/AllocationToken.java | 2 +- .../google/registry/tools/GenerateAllocationTokensCommand.java | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/google/registry/batch/DeleteProberDataAction.java b/core/src/main/java/google/registry/batch/DeleteProberDataAction.java index f39aa3075..4a74e7abc 100644 --- a/core/src/main/java/google/registry/batch/DeleteProberDataAction.java +++ b/core/src/main/java/google/registry/batch/DeleteProberDataAction.java @@ -64,7 +64,7 @@ import org.joda.time.Duration; auth = Auth.AUTH_ADMIN) public class DeleteProberDataAction implements Runnable { - // TODO(b/323026070): Add email alert on failure of this action + // TODO(b/346390641): Add email alert on failure of this action private static final FluentLogger logger = FluentLogger.forEnclosingClass(); /** diff --git a/core/src/main/java/google/registry/flows/domain/DomainCreateFlow.java b/core/src/main/java/google/registry/flows/domain/DomainCreateFlow.java index 700b43ac0..94d7166be 100644 --- a/core/src/main/java/google/registry/flows/domain/DomainCreateFlow.java +++ b/core/src/main/java/google/registry/flows/domain/DomainCreateFlow.java @@ -266,7 +266,6 @@ public final class DomainCreateFlow implements MutatingFlow { validateLaunchCreateNotice(launchCreate.get().getNotice(), domainLabel, isSuperuser, now); } boolean isSunriseCreate = hasSignedMarks && (tldState == START_DATE_SUNRISE); - // TODO(sarahbot@): Add check for valid EPP actions on the token Optional allocationToken = allocationTokenFlowUtils.verifyAllocationTokenCreateIfPresent( command, diff --git a/core/src/main/java/google/registry/model/domain/token/AllocationToken.java b/core/src/main/java/google/registry/model/domain/token/AllocationToken.java index 97aacbacc..dcd897c4e 100644 --- a/core/src/main/java/google/registry/model/domain/token/AllocationToken.java +++ b/core/src/main/java/google/registry/model/domain/token/AllocationToken.java @@ -139,7 +139,7 @@ public class AllocationToken extends UpdateAutoTimestampEntity implements Builda /** Token saved on a TLD to use if no other token is passed from the client */ DEFAULT_PROMO(/* isOneTimeUse= */ false), /** This is the old name for what is now BULK_PRICING. */ - // TODO(sarahbot@): Remove this type once all tokens of this type have been scrubbed from the + // TODO(b/261763205): Remove this type once all tokens of this type have been scrubbed from the // database @Deprecated PACKAGE(/* isOneTimeUse= */ false), diff --git a/core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java b/core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java index d77d69549..7a0abb45d 100644 --- a/core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java +++ b/core/src/main/java/google/registry/tools/GenerateAllocationTokensCommand.java @@ -293,7 +293,7 @@ class GenerateAllocationTokensCommand implements Command { // tokens should only be scheduled to end with a brief time period before the status // transition occurs so that no new domains are registered using that token between when the // status is scheduled and when the transition occurs. - // TODO(@sarahbot): Create a cleaner way to handle ending bulk pricing packages once we + // TODO(b/261763205): Create a cleaner way to handle ending bulk pricing packages once we // actually have customers using them boolean hasEnding = tokenStatusTransitions.containsValue(TokenStatus.ENDED)