mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-21 07:24:26 +00:00
Code Issues Releases Wiki Activity

Normalize expected exception handling in tests

Browse Source 
This removes exception rules that aren't used and switches over
existing uses of ExceptedException to ExceptionRule when possible.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=129013329
This commit is contained in:
Ben McIlwain
2016-08-02 19:16:19 -04:00
committed by Justine Tunney
parent 60fc27646a
commit 9e65acc937
11 changed files with 14 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
javatests/google/registry/xjc/XmlTestdataTest.java
+3 -3
View File
@@ -19,6 +19,7 @@ import static google.registry.util.ResourceUtils.readResourceUtf8;
import static google.registry.xjc.XjcXmlTransformer.unmarshal;
import static java.nio.charset.StandardCharsets.UTF_8;
import google.registry.testing.ExceptionRule;
import google.registry.xjc.epp.XjcEpp;
import google.registry.xjc.rde.XjcRdeDeposit;
import java.io.ByteArrayInputStream;
@@ -26,7 +27,6 @@ import org.junit.Rule;
import org.junit.experimental.theories.DataPoints;
import org.junit.experimental.theories.Theories;
import org.junit.experimental.theories.Theory;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
/**
@@ -37,7 +37,7 @@ import org.junit.runner.RunWith;
public class XmlTestdataTest {
@Rule
public final ExpectedException thrown = ExpectedException.none();
public final ExceptionRule thrown = new ExceptionRule();
private static class Example {
final ByteArrayInputStream xmlStream;
@@ -151,7 +151,7 @@ public class XmlTestdataTest {
@Theory
public void testInvalid(Evil v) throws Exception {
thrown.expectMessage(v.error);
thrown.expect(Throwable.class, v.error);
unmarshal(XjcObject.class, v.xmlStream);
}
}