mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-07 22:15:30 +00:00
Code Issues Releases Wiki Activity

Decentralize how registry phase checks are done in flows

Browse Source 
Very few flows actually check the phase. Push the checks down to the leaf
flows so that we can remove the inherited code from ResourceFlow and replace
it with utility methods. In the process, document and test two places that
throw the exception but did not previously test it.

This introduces a temporary hack in BaseDomainCreateFlow that does something
specific for DomainApplicationCreateFlow. It will go away literally tomorrow
when I flatten that flow.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135480538
This commit is contained in:
cgoldfeder
2016-10-07 08:52:46 -07:00
committed by Ben McIlwain
parent aaa84d6ec6
commit a09d48a4a5
18 changed files with 166 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
java/google/registry/flows/domain/ClaimsCheckFlow.java
View File

@@ -18,18 +18,18 @@ import static google.registry.flows.ResourceFlowUtils.verifyTargetIdCount;
import static google.registry.flows.domain.DomainFlowUtils.checkAllowedAccessToTld;
import static google.registry.flows.domain.DomainFlowUtils.validateDomainName;
import static google.registry.flows.domain.DomainFlowUtils.validateDomainNameWithIdnTables;
import static google.registry.flows.domain.DomainFlowUtils.verifyNotInPredelegation;
import static google.registry.model.domain.launch.LaunchPhase.CLAIMS;
import static google.registry.model.eppoutput.Result.Code.SUCCESS;
import static google.registry.util.DateTimeUtils.isAtOrAfter;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import com.google.common.net.InternetDomainName;
import google.registry.config.ConfigModule.Config;
import google.registry.flows.EppException;
import google.registry.flows.EppException.CommandUseErrorException;
import google.registry.flows.LoggedInFlow;
import google.registry.flows.exceptions.BadCommandForRegistryPhaseException;
import google.registry.model.domain.DomainCommand.Check;
import google.registry.model.domain.launch.LaunchCheckExtension;
import google.registry.model.domain.launch.LaunchCheckResponseExtension;
@@ -49,15 +49,14 @@ import javax.inject.Inject;
* An EPP flow that checks whether strings are trademarked.
*
* @error {@link google.registry.flows.domain.DomainFlowUtils.NotAuthorizedForTldException}
* @error {@link google.registry.flows.exceptions.BadCommandForRegistryPhaseException}
* @error {@link google.registry.flows.exceptions.TooManyResourceChecksException}
* @error {@link DomainFlowUtils.BadCommandForRegistryPhaseException}
* @error {@link DomainFlowUtils.TldDoesNotExistException}
* @error {@link ClaimsCheckNotAllowedInSunrise}
* @error {@link ClaimsPeriodEndedException}
*/
public final class ClaimsCheckFlow extends LoggedInFlow {
public static final ImmutableSet<TldState> DISALLOWED_TLD_STATES =
Sets.immutableEnumSet(TldState.PREDELEGATION, TldState.SUNRISE);
@Inject ResourceCommand resourceCommand;
@Inject @Config("maxChecks") int maxChecks;
@Inject ClaimsCheckFlow() {}
@@ -81,9 +80,14 @@ public final class ClaimsCheckFlow extends LoggedInFlow {
if (seenTlds.add(tld)) {
checkAllowedAccessToTld(getAllowedTlds(), tld);
Registry registry = Registry.get(tld);
if ((!isSuperuser && DISALLOWED_TLD_STATES.contains(registry.getTldState(now)))
|| isAtOrAfter(now, registry.getClaimsPeriodEnd())) {
throw new BadCommandForRegistryPhaseException();
if (!isSuperuser) {
verifyNotInPredelegation(registry, now);
if (registry.getTldState(now) == TldState.SUNRISE) {
throw new ClaimsCheckNotAllowedInSunrise();
}
if (isAtOrAfter(now, registry.getClaimsPeriodEnd())) {
throw new ClaimsPeriodEndedException();
}
}
}
String claimKey = ClaimsListShard.get().getClaimKey(domainName.parts().get(0));
@@ -96,4 +100,18 @@ public final class ClaimsCheckFlow extends LoggedInFlow {
null,
ImmutableList.of(LaunchCheckResponseExtension.create(CLAIMS, launchChecksBuilder.build())));
}
/** Claims checks are not allowed during sunrise. */
static class ClaimsCheckNotAllowedInSunrise extends CommandUseErrorException {
public ClaimsCheckNotAllowedInSunrise() {
super("Claims checks are not allowed during sunrise");
}
}
/** The claims period has ended. */
static class ClaimsPeriodEndedException extends CommandUseErrorException {
public ClaimsPeriodEndedException() {
super("The claims period has ended");
}
}
}