mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-08-21 06:36:15 +00:00
Code Issues Releases Wiki Activity

Embed a ZonedDateTime as the UpdateAutoTimestamp in SQL (#1033)

Browse Source 
* Embed a ZonedDateTime as the UpdateAutoTimestamp in SQL

This means we can get rid of the converter and more importantly, means
that reading the object from SQL does not affect the last-read time (the
test added to UpdateAutoTimestampTest failed prior to the production
code change).

For now we keep both time fields in UpdateAutoTimestamp however
post-migration, we can remove the joda-time field if we wish.

Note: I'm not sure why <now> is the time that we started getting
LazyInitializationExceptions in the LegacyHistoryObject and
ReplayExtension tests but we can solve that by just examining /
initializing the object within the transaction.
This commit is contained in:
gbrodman
2021-03-29 11:59:08 -04:00
committed by GitHub
parent 1e650bd0a1
commit a4e078305d
28 changed files with 2875 additions and 2932 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/resources/META-INF/persistence.xml
-1
View File
@@ -98,7 +98,6 @@
<class>google.registry.persistence.converter.StringSetConverter</class>
<class>google.registry.persistence.converter.TldStateTransitionConverter</class>
<class>google.registry.persistence.converter.TransferServerApproveEntitySetConverter</class>
<class>google.registry.persistence.converter.UpdateAutoTimestampConverter</class>
<class>google.registry.persistence.converter.ZonedDateTimeConverter</class>
<!-- Generated converters for VKey -->