diff --git a/core/src/test/java/google/registry/rdap/RdapActionBaseTestCase.java b/core/src/test/java/google/registry/rdap/RdapActionBaseTestCase.java index b09d9b5b7..062badbd3 100644 --- a/core/src/test/java/google/registry/rdap/RdapActionBaseTestCase.java +++ b/core/src/test/java/google/registry/rdap/RdapActionBaseTestCase.java @@ -298,9 +298,13 @@ have failed to comply with these terms.", } JsonFileBuilder addNameserver(String name, String handle) { + return addNameserver(Idn.toASCII(name), name, handle); + } + + JsonFileBuilder addNameserver(String punycodeName, String unicodeName, String handle) { return putNext( - "NAMESERVER_NAME_", Idn.toASCII(name), - "NAMESERVER_UNICODE_NAME_", name, + "NAMESERVER_NAME_", punycodeName, + "NAMESERVER_UNICODE_NAME_", unicodeName, "NAMESERVER_HANDLE_", handle); } diff --git a/core/src/test/java/google/registry/rdap/RdapNameserverActionTest.java b/core/src/test/java/google/registry/rdap/RdapNameserverActionTest.java index 4c916313f..513896f5a 100644 --- a/core/src/test/java/google/registry/rdap/RdapNameserverActionTest.java +++ b/core/src/test/java/google/registry/rdap/RdapNameserverActionTest.java @@ -17,6 +17,8 @@ package google.registry.rdap; import static com.google.common.truth.Truth.assertThat; import static google.registry.testing.DatabaseHelper.createTld; import static google.registry.testing.DatabaseHelper.persistResource; +import static google.registry.testing.FullFieldsTestEntityHelper.makeAndPersistHost; +import static google.registry.testing.FullFieldsTestEntityHelper.makePunycodedHost; import static google.registry.testing.FullFieldsTestEntityHelper.makeRegistrar; import static google.registry.testing.GsonSubject.assertAboutJson; import static org.mockito.Mockito.verify; @@ -27,7 +29,6 @@ import google.registry.rdap.RdapMetrics.SearchType; import google.registry.rdap.RdapMetrics.WildcardType; import google.registry.rdap.RdapSearchResults.IncompletenessWarningType; import google.registry.request.Action; -import google.registry.testing.FullFieldsTestEntityHelper; import java.util.Optional; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -43,20 +44,17 @@ class RdapNameserverActionTest extends RdapActionBaseTestCase", Registrar.State.ACTIVE, 102L)); // external - FullFieldsTestEntityHelper.makeAndPersistHost( - "ns1.domain.external", "9.10.11.12", clock.nowUtc().minusYears(1)); + makeAndPersistHost("ns1.domain.external", "9.10.11.12", clock.nowUtc().minusYears(1)); } @Test @@ -80,6 +77,14 @@ class RdapNameserverActionTest extends RdapActionBaseTestCase