mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-19 06:32:00 +00:00
Code Issues Releases Wiki Activity

Remove all vestiges of memcache

Browse Source 
Memcache is already off but now it's not in the code anymore.

This includes removing domain creation failfast, since that is actually
slower now than just running the flow - all you gain is a non-transactional
read over a transactional read, but the cost is that you always pay that
read, which is going to drive up latency.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=158183506
This commit is contained in:
cgoldfeder
2017-06-14 10:28:24 -04:00
committed by Ben McIlwain
parent 445faab977
commit ae039aa0d8
37 changed files with 29 additions and 341 deletions
Download Patch File Download Diff File Expand all files Collapse all files
javatests/google/registry/testing/DatastoreHelper.java
+6 -6
View File
@@ -829,9 +829,9 @@ public class DatastoreHelper {
saveResource(resource, wantBackup);
}});
// Force the session cache to be cleared so that when we read the resource back, we read from
// Datastore (or memcache) and not from the session cache. This is needed to trigger Objectify's
// load process (unmarshalling entity protos to POJOs, nulling out empty collections, calling
// @OnLoad methods, etc.) which is bypassed for entities loaded from the session cache.
// Datastore and not from the session cache. This is needed to trigger Objectify's load process
// (unmarshalling entity protos to POJOs, nulling out empty collections, calling @OnLoad
// methods, etc.) which is bypassed for entities loaded from the session cache.
ofy().clearSessionCache();
return ofy().load().entity(resource).now();
}
@@ -872,7 +872,7 @@ public class DatastoreHelper {
}});
}
// Force the session to be cleared so that when we read it back, we read from Datastore
// and not from the transaction cache or memcache.
// and not from the transaction's session cache.
ofy().clearSessionCache();
for (R resource : resources) {
ofy().load().entity(resource).now();
@@ -984,7 +984,7 @@ public class DatastoreHelper {
ofy().saveWithoutBackup().entities(resources);
}});
// Force the session to be cleared so that when we read it back, we read from Datastore
// and not from the transaction cache or memcache.
// and not from the transaction's session cache.
ofy().clearSessionCache();
return ImmutableList.copyOf(ofy().load().entities(resources).values());
}
@@ -992,7 +992,7 @@ public class DatastoreHelper {
public static void deleteResource(final Object resource) {
ofy().deleteWithoutBackup().entity(resource).now();
// Force the session to be cleared so that when we read it back, we read from Datastore and
// not from the transaction cache or memcache.
// not from the transaction's session cache.
ofy().clearSessionCache();
}