mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-09 15:43:52 +00:00
Code Issues Releases Wiki Activity

Remove final on @ParametersDelegate field

Browse Source 
Compile-time constant inlining may interfere with JCommander's processing if a field is made final - @ParametersDelegate fields are particularly misleading.  Remove the one instance of that and add warning comments elsewhere.  See

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136469351
This commit is contained in:
nickfelt
2016-10-18 07:14:23 -07:00
committed by Ben McIlwain
parent e127920f20
commit afa4d66601
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/google/registry/tools/RegistrarActivityReportCommand.java
View File

@@ -36,8 +36,9 @@ import org.joda.time.format.DateTimeFormatter;
@Parameters(separators = " =", commandDescription = "Generates a registrar activity report.")
final class RegistrarActivityReportCommand implements Command {
// Do not make this final - compile-time constant inlining may interfere with JCommander.
@ParametersDelegate
private final BigqueryParameters bigqueryParameters = new BigqueryParameters();
private BigqueryParameters bigqueryParameters = new BigqueryParameters();
@Parameter(
names = {"-t", "--tld"},