mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-08-20 22:26:12 +00:00
Code Issues Releases Wiki Activity

Increment proxy metrics by reciprocal of proxy metrics ratio (#2780)

Browse Source 
This is necessary so that the total number of requests/responses adds up
correctly even though some fraction of them are only being recorded. It uses
stochastic rounding so that the totals add up correctly even when the reciprocal
of the ratio isn't an integer.

This is a follow-up to PR #2772.
This commit is contained in:
Ben McIlwain
2025-07-02 15:52:47 +00:00
committed by GitHub
parent 0e8cd75a58
commit b27b077638
2 changed files with 38 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proxy/src/test/java/google/registry/proxy/metric/BackendMetricsTest.java
+14 -5
View File
@@ -112,9 +112,18 @@ class BackendMetricsTest {
@Test
void testSuccess_multipleResponses() {
Random mockRandom = mock(Random.class);
metrics = new BackendMetrics(0.2, mockRandom);
// The third response won't be logged.
when(mockRandom.nextDouble()).thenReturn(.1, .04, .5, .15);
metrics = new BackendMetrics(0.3, mockRandom);
// The reciprocal of this metrics ratio is 3.3..., so depending on stochastic rounding each
// response will be recorded as either 3 or 4 (which we hard-code in test by mocking the RNG).
when(mockRandom.nextDouble())
.thenReturn(
/* record response1 */ .1,
/* ... as 3 */ .5,
/* record response2 */ .04,
/* ... as 4 */ .2,
/* don't record response3 (skips stochastic rounding) */ .5,
/* record response4 */ .15,
/* ... as 3 */ .5);
String content1 = "some response";
String content2 = "other response";
String content3 = "a very bad response";
@@ -130,9 +139,9 @@ class BackendMetricsTest {
assertThat(BackendMetrics.requestsCounter).hasNoOtherValues();
assertThat(BackendMetrics.requestBytes).hasNoOtherValues();
assertThat(BackendMetrics.responsesCounter)
.hasValueForLabels(2, protocol, certHash, "200 OK")
.hasValueForLabels(7, protocol, certHash, "200 OK")
.and()
.hasValueForLabels(1, protocol, certHash, "400 Bad Request")
.hasValueForLabels(3, protocol, certHash, "400 Bad Request")
.and()
.hasNoOtherValues();
assertThat(BackendMetrics.responseBytes)