Only apply Google Java format to changed lines (#176)

mirror of https://github.com/google/nomulus synced 2026-09-19 22:44:26 +00:00

* Only apply Google Java format to changed lines

* Only apply Google Java format to changed lines

* Only apply Google Java format to changed regions

Diffs are relative to origin/master.

Three tasks are added:
- javaIncrementalFormatCheck is added to the build workflow, and
  will abort build if format violations are found.
- javaIncrementalFormatApply needs to be manually invoked to correct
  format violations, the same behavior as spotlessApply.
- javaIncrementalFormatDryRun shows the changes that would happen if
  javaIncrementalFormatApply is invoked.

These tasks work from the root directory and process the buildSrc directory
too.

The Spotless Java config is removed.

* Only apply Google Java format to changed regions

Diffs are relative to origin/master.

Three tasks are added:
- javaIncrementalFormatCheck is added to the build workflow, and
  will abort build if format violations are found.
- javaIncrementalFormatApply needs to be manually invoked to correct
  format violations, the same behavior as spotlessApply.
- javaIncrementalFormatDryRun shows the changes that would happen if
  javaIncrementalFormatApply is invoked.

These tasks work from the root directory and process the buildSrc directory
too.

The Spotless Java config is removed.

* Only apply Google Java format to changed regions

Diffs are relative to origin/master.

Three tasks are added:
- javaIncrementalFormatCheck is added to the build workflow, and
  will abort build if format violations are found.
- javaIncrementalFormatApply needs to be manually invoked to correct
  format violations, the same behavior as spotlessApply.
- javaIncrementalFormatDryRun shows the changes that would happen if
  javaIncrementalFormatApply is invoked.

These tasks work from the root directory and process the buildSrc directory
too.

The Spotless Java config is removed.

* Only apply Google Java format to changed regions

Diffs are relative to origin/master.

Three tasks are added:
- javaIncrementalFormatCheck is added to the build workflow, and
  will abort build if format violations are found.
- javaIncrementalFormatApply needs to be manually invoked to correct
  format violations, the same behavior as spotlessApply.
- javaIncrementalFormatDryRun shows the changes that would happen if
  javaIncrementalFormatApply is invoked.

These tasks work from the root directory and process the buildSrc directory
too.

The Spotless Java config is removed.

This commit is contained in:

Weimin Yu

2019-08-29 16:04:34 -04:00

committed by

GitHub

parent dd4300fce7

commit b5ef99a8f8

6 changed files with 286 additions and 11 deletions

									
										config/presubmits.py
									
		+2
		-1
	
												View File
												
				@@ -78,7 +78,8 @@ PRESUBMITS = {

				        r".*Copyright 20\d{2} The Nomulus Authors\. All Rights Reserved\.",

				        ("java", "js", "soy", "sql", "py", "sh", "gradle"), {

				            ".git", "/build/", "/generated/", "node_modules/",

				            "JUnitBackports.java", "registrar_bin.", "registrar_dbg."

				            "JUnitBackports.java", "registrar_bin.", "registrar_dbg.",

				            "google-java-format-diff.py"

				        }, REQUIRED):

				        "File did not include the license header.",