mirror of
https://github.com/google/nomulus
synced 2026-09-19 06:32:00 +00:00
Get rid of custom ExceptionRule methods
The only remaining methods on ExceptionRule after this are methods that also exist on ExpectedException, which will allow us to, in the next CL, swap out the one for the other and then run the automated refactoring to turn it all into assertThrows/expectThrows. Note that there were some assertions about root causes that couldn't easily be turned into ExpectedException invocations, so I simply converted them directly to usages of assertThrows/expectThrows. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=178623431
This commit is contained in:
@@ -89,7 +89,8 @@ public class DeleteEntityActionTest {
|
||||
Entity entity = new Entity("not", "here");
|
||||
String rawKey = KeyFactory.keyToString(entity.getKey());
|
||||
action.rawKeys = rawKey;
|
||||
thrown.expect(BadRequestException.class, "Could not find entity with key " + rawKey);
|
||||
thrown.expect(BadRequestException.class);
|
||||
thrown.expectMessage("Could not find entity with key " + rawKey);
|
||||
action.run();
|
||||
}
|
||||
|
||||
@@ -101,7 +102,8 @@ public class DeleteEntityActionTest {
|
||||
Entity entity = new Entity("non", "existent");
|
||||
String rawKey = KeyFactory.keyToString(entity.getKey());
|
||||
action.rawKeys = String.format("%s,%s", ofyKey, rawKey);
|
||||
thrown.expect(BadRequestException.class, "Could not find entity with key " + rawKey);
|
||||
thrown.expect(BadRequestException.class);
|
||||
thrown.expectMessage("Could not find entity with key " + rawKey);
|
||||
action.run();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user