mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-07 05:56:49 +00:00
Code Issues Releases Wiki Activity

Remove AppEngineServiceUtils (#2003)

Browse Source 
The only method that is called from this class is setNumInstances. However we
don't current use `nomulus set_num_instances` anywhere. If we need to change
the number of instances, it is either done by updating appengine-web.xml, which
is deployed by Spinnaker, or doing it manually as a break-glass fix via gcloud
or on Pantheon.
This commit is contained in:
Lai Jiang
2023-04-21 10:11:12 -04:00
committed by GitHub
parent 23fb69a682
commit bd0cea0d87
9 changed files with 1 additions and 712 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
release/rollback/steps.py
View File

@@ -33,8 +33,7 @@ class RollbackStep:
Two steps are handled differently. The _UpdateDeployTag step gets a piped
shell command, which needs to be handled differently. The
_SetManualScalingNumInstances step uses the AppEngine Admin API client in
this package to set the number of instances. The Nomulus set_num_instances
command is not working right now.
this package to set the number of instances.
"""
description: str