mirror of
https://github.com/google/nomulus
synced 2026-08-31 13:17:02 +00:00
RDAP: Include remarks only in object classes
The APNIC conformance checker points out that, according to RFC 7483, RDAP remarks should be included only as part of object classes such as domains, nameservers and entities, not in help responses and so on. Note that something is amiss here -- If RFC 7483 is read strictly, the remarks boilerplate for domain, nameserver and entity search results should appear not at the top level, as we currently do, but as part of each constituent object. However, the conformance checker does not seem to complain about that. So I have added this to the RDAP questions list, and am leaving the boilerplate at the top level for now. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=117557594
This commit is contained in:
committed by
Justine Tunney
parent
c8d655e416
commit
c25cfa626b
@@ -107,7 +107,7 @@ public class RdapNameserverSearchAction extends RdapActionBase {
|
||||
}
|
||||
ImmutableMap.Builder<String, Object> builder = new ImmutableMap.Builder<>();
|
||||
builder.put("nameserverSearchResults", results);
|
||||
RdapJsonFormatter.addTopLevelEntries(builder, BoilerplateType.OTHER, null, rdapLinkBase);
|
||||
RdapJsonFormatter.addTopLevelEntries(builder, BoilerplateType.NAMESERVER, null, rdapLinkBase);
|
||||
return builder.build();
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user