mirror of
https://github.com/google/nomulus
synced 2026-01-05 04:56:03 +00:00
Refactor GetEppResourceCommand hierarchy
This refactors the GetEppResourceCommand hierarchy a bit so that instead of using the type param on the class to do implicit loading (which doesn't work that well any more for domain applications anyway), we just do the loading in each child class and rely on the parent class only for printing and setting common flags. I did this to make it possible for loadByForeignKey() to have strong typing (in a future CL), but I think this changes stands on its own merits for making the logic here more straightforward and actually somewhat shorter. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134115072
This commit is contained in:
@@ -14,6 +14,8 @@
|
||||
|
||||
package google.registry.tools;
|
||||
|
||||
import static google.registry.model.EppResourceUtils.loadByForeignKey;
|
||||
|
||||
import com.beust.jcommander.Parameter;
|
||||
import com.beust.jcommander.Parameters;
|
||||
import google.registry.model.host.HostResource;
|
||||
@@ -21,9 +23,8 @@ import google.registry.tools.Command.GtechCommand;
|
||||
import java.util.List;
|
||||
|
||||
/** Command to show one or more host resources. */
|
||||
@Parameters(separators = " =", commandDescription = "Show host record(s)")
|
||||
final class GetHostCommand extends GetEppResourceCommand<HostResource>
|
||||
implements GtechCommand {
|
||||
@Parameters(separators = " =", commandDescription = "Show host resource(s)")
|
||||
final class GetHostCommand extends GetEppResourceCommand implements GtechCommand {
|
||||
|
||||
@Parameter(
|
||||
description = "Fully qualified host name(s)",
|
||||
@@ -31,9 +32,10 @@ final class GetHostCommand extends GetEppResourceCommand<HostResource>
|
||||
private List<String> mainParameters;
|
||||
|
||||
@Override
|
||||
public void processParameters() {
|
||||
public void runAndPrint() {
|
||||
for (String hostName : mainParameters) {
|
||||
printResource(hostName);
|
||||
printResource(
|
||||
"Host", hostName, loadByForeignKey(HostResource.class, hostName, readTimestamp));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user