diff --git a/console-webapp/src/app/registrar/registrarDetails.component.ts b/console-webapp/src/app/registrar/registrarDetails.component.ts index bd0689525..3221a238a 100644 --- a/console-webapp/src/app/registrar/registrarDetails.component.ts +++ b/console-webapp/src/app/registrar/registrarDetails.component.ts @@ -75,7 +75,7 @@ export class RegistrarDetailsComponent implements OnInit { } checkOteStatus() { - this.router.navigate(['ote-status/', this.registrarInEdit.registrarId], { + this.router.navigate(['ote-status', this.registrarInEdit.registrarId], { queryParamsHandling: 'merge', }); } diff --git a/core/src/main/java/google/registry/model/domain/DomainCommand.java b/core/src/main/java/google/registry/model/domain/DomainCommand.java index 9f59502ca..14b099c75 100644 --- a/core/src/main/java/google/registry/model/domain/DomainCommand.java +++ b/core/src/main/java/google/registry/model/domain/DomainCommand.java @@ -158,12 +158,12 @@ public class DomainCommand { throws InvalidReferencesException, ParameterValuePolicyErrorException { Create clone = clone(this); clone.nameservers = linkHosts(nullSafeImmutableCopy(clone.nameserverHostNames), now); - if (registrantContactId != null) { - throw new RegistrantProhibitedException(); - } if (!isNullOrEmpty(foreignKeyedDesignatedContacts)) { throw new ContactsProhibitedException(); } + if (registrantContactId != null) { + throw new RegistrantProhibitedException(); + } return clone; } diff --git a/core/src/main/java/google/registry/xml/xsd/domain.xsd b/core/src/main/java/google/registry/xml/xsd/domain.xsd index a6e5ebe9f..fb72f3341 100644 --- a/core/src/main/java/google/registry/xml/xsd/domain.xsd +++ b/core/src/main/java/google/registry/xml/xsd/domain.xsd @@ -47,6 +47,8 @@ Child elements of the command. minOccurs="0"/> + @@ -98,6 +100,22 @@ If attributes, addresses are optional and follow the structure defined in the host mapping. --> + + + + + + + + + + + + + + + + @@ -198,6 +216,8 @@ Data elements that can be added or removed. + @@ -299,6 +319,8 @@ Child response elements. minOccurs="0" maxOccurs="11"/> + + loadEppResourceCommand("domain_create_with_contacts.xml")); + ContactsProhibitedException.class, () -> create.cloneAndLinkReferences(fakeClock.now())); } @Test @@ -138,9 +139,10 @@ class DomainCommandTest extends ResourceCommandTestCase { void testUpdate_cloneAndLinkReferences_failsWithContacts() throws Exception { persistActiveHost("ns1.example.com"); persistActiveHost("ns2.example.com"); + DomainCommand.Update update = + (DomainCommand.Update) loadEppResourceCommand("domain_update_with_contacts.xml"); assertThrows( - FlowUtils.GenericXmlSyntaxErrorException.class, - () -> loadEppResourceCommand("domain_update_with_contacts.xml")); + ContactsProhibitedException.class, () -> update.cloneAndLinkReferences(fakeClock.now())); } @Test diff --git a/prober/src/main/resources/google/registry/monitoring/blackbox/message/create.xml b/prober/src/main/resources/google/registry/monitoring/blackbox/message/create.xml index 111344025..c0f6f6831 100644 --- a/prober/src/main/resources/google/registry/monitoring/blackbox/message/create.xml +++ b/prober/src/main/resources/google/registry/monitoring/blackbox/message/create.xml @@ -9,8 +9,6 @@ ns.fake-domain.tld google-mon - google-mon - google-mon insecure