mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-07-25 09:32:56 +00:00
Code Issues Releases Wiki Activity

Refactor ConcurrentHashMap creation code to a helper method

Browse Source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=132352263
This commit is contained in:
shikhman
2016-09-07 12:06:26 -04:00
committed by Ben McIlwain
parent 0538c1e210
commit dbb9ef80c5
3 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/google/registry/monitoring/metrics/Counter.java
+4 -12
View File
@@ -15,6 +15,8 @@
package google.registry.monitoring.metrics;
import static com.google.common.base.Preconditions.checkArgument;
import static google.registry.monitoring.metrics.MetricsUtils.DEFAULT_CONCURRENCY_LEVEL;
import static google.registry.monitoring.metrics.MetricsUtils.newConcurrentHashMap;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableList;
@@ -40,15 +42,6 @@ import org.joda.time.Instant;
public final class Counter extends AbstractMetric<Long>
implements SettableMetric<Long>, IncrementableMetric {
/**
* The below constants replicate the default initial capacity, load factor, and concurrency level
* for {@link ConcurrentHashMap} as of Java SE 7. They are hardcoded here so that the concurrency
* level in {@code valueLocks} below can be set identically.
*/
private static final int HASHMAP_INITIAL_CAPACITY = 16;
private static final float HASHMAP_LOAD_FACTOR = 0.75f;
private static final int HASHMAP_CONCURRENCY_LEVEL = 16;
/**
* A map of the {@link Counter} values, with a list of label values as the keys.
*
@@ -63,8 +56,7 @@ public final class Counter extends AbstractMetric<Long>
* implementations of {@link MetricWriter} to encode resets of monotonic counters.
*/
private final ConcurrentHashMap<ImmutableList<String>, Instant> valueStartTimestamps =
new ConcurrentHashMap<>(
HASHMAP_INITIAL_CAPACITY, HASHMAP_LOAD_FACTOR, HASHMAP_CONCURRENCY_LEVEL);
newConcurrentHashMap(DEFAULT_CONCURRENCY_LEVEL);
/**
* A fine-grained lock to ensure that {@code values} and {@code valueStartTimestamps} are modified
@@ -73,7 +65,7 @@ public final class Counter extends AbstractMetric<Long>
*
* @see Striped
*/
private final Striped<Lock> valueLocks = Striped.lock(HASHMAP_CONCURRENCY_LEVEL);
private final Striped<Lock> valueLocks = Striped.lock(DEFAULT_CONCURRENCY_LEVEL);
Counter(
String name,