From e94ba8d2affa2cdff39badc628533cc14a123b99 Mon Sep 17 00:00:00 2001
From: lukes <lukes@google.com>
Date: Tue, 20 Jun 2017 08:46:56 -0700
Subject: [PATCH] Delete private="true" from .soy files

private="true" has never done very much unfortunately. There is an alternate
way to mark templates as private by setting 'visibility="private"' which does
get enforced both by the soy compiler and by custom per-language strategies in
the various backends.

Unfortunately, it isn't possible to safely migrate from one to the other since
users may be calling these templates from server side soy which enforces
visibility via a runtime exception.  So they are just being deleted.

LSC: https://docs.google.com/document/d/1aOM_tBmanDQolF8mAuB0y29yB76cmYS5qOVYBAzFzyw/edit#

Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=159565458
---
 java/google/registry/ui/soy/registrar/Console.soy         | 2 +-
 java/google/registry/ui/soy/registrar/ContactSettings.soy | 8 ++++----
 java/google/registry/ui/soy/registrar/Domain.soy          | 2 +-
 java/google/registry/ui/soy/registrar/WhoisSettings.soy   | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/java/google/registry/ui/soy/registrar/Console.soy b/java/google/registry/ui/soy/registrar/Console.soy
index d1eee9098..36b2336fb 100644
--- a/java/google/registry/ui/soy/registrar/Console.soy
+++ b/java/google/registry/ui/soy/registrar/Console.soy
@@ -75,7 +75,7 @@
 
 
 /** Sidebar nav. Ids on each elt for testing only. */
-{template .navbar_ private="true"}
+{template .navbar_ visibility="private"}
   {@param showPaymentLink: bool}
   <div id="reg-nav" class="{css kd-content-sidebar}">
     <ul id="reg-navlist">
diff --git a/java/google/registry/ui/soy/registrar/ContactSettings.soy b/java/google/registry/ui/soy/registrar/ContactSettings.soy
index 4f98c7673..76b2d6f00 100644
--- a/java/google/registry/ui/soy/registrar/ContactSettings.soy
+++ b/java/google/registry/ui/soy/registrar/ContactSettings.soy
@@ -176,7 +176,7 @@
 
 
 /** @private */
-{template .contactTypeSettingsView_ private="true"}
+{template .contactTypeSettingsView_ visibility="private"}
   {@param item: map<string, ?>}
   {@param possibleTypesLookup: list<list<string>>}
   {@param actualTypesLookup: map<string, bool>}
@@ -217,7 +217,7 @@
 
 
 /** @private */
-{template .contactTypeSettingsEdit_ private="true"}
+{template .contactTypeSettingsEdit_ visibility="private"}
   {@param item: map<string, ?>}
   {@param namePrefix: string}
   {@param possibleTypesLookup: list<list<string>>}
@@ -263,7 +263,7 @@
 
 
 /** @private */
-{template .whoisVisibleRadios_ private="true"}
+{template .whoisVisibleRadios_ visibility="private"}
   {@param description: string}
   {@param? note: string}
   {@param fieldName: string}
@@ -297,7 +297,7 @@
 
 
 /** @private */
-{template .contactCheckboxes_ private="true"}
+{template .contactCheckboxes_ visibility="private"}
   {@param namePrefix: string}
   {@param actualTypesLookup: map<string, bool>}
   {@param possibleTypesLookup: list<list<string>>}
diff --git a/java/google/registry/ui/soy/registrar/Domain.soy b/java/google/registry/ui/soy/registrar/Domain.soy
index 545aee988..107de650f 100644
--- a/java/google/registry/ui/soy/registrar/Domain.soy
+++ b/java/google/registry/ui/soy/registrar/Domain.soy
@@ -162,7 +162,7 @@
 
 
 /** Renders an input form row for a specific type of contact. */
-{template .showContact_ private="true"}
+{template .showContact_ visibility="private"}
   {@param contacts: list<map<string, ?>>} /** List of EPP domain:contacts. */
   {@param type: string} /** Type of contact (e.g. admin, tech) */
   {foreach $contact in $contacts}
diff --git a/java/google/registry/ui/soy/registrar/WhoisSettings.soy b/java/google/registry/ui/soy/registrar/WhoisSettings.soy
index 2bddc849d..aba27c371 100644
--- a/java/google/registry/ui/soy/registrar/WhoisSettings.soy
+++ b/java/google/registry/ui/soy/registrar/WhoisSettings.soy
@@ -78,7 +78,7 @@
 /**
  * Contact info.
  */
-{template .contactInfo_ private="true"}
+{template .contactInfo_ visibility="private"}
   {@param emailAddress: string}
   {@param readonly: bool}
   {@param? localizedAddress: ?}
@@ -142,7 +142,7 @@
 /**
  * Read-only view of address.
  */
-{template .viewAddress_ private="true"}
+{template .viewAddress_ visibility="private"}
   {@param id: string}
   {@param street: list<string>}
   {@param city: string}
@@ -177,7 +177,7 @@
 /**
  * Editor of address.
  */
-{template .editAddress_ private="true"}
+{template .editAddress_ visibility="private"}
   {@param id: string}
   {@param? street: list<string>}
   {@param? city: string}