From ea995cf801fb30519a0be29bb61e82dd3e182cb8 Mon Sep 17 00:00:00 2001 From: larryruili Date: Tue, 10 Apr 2018 14:15:52 -0700 Subject: [PATCH] Make lock index parameters non-optional The optional code has been around for a while, we can get rid of it now. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=192344612 --- java/google/registry/dns/DnsModule.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/java/google/registry/dns/DnsModule.java b/java/google/registry/dns/DnsModule.java index 6c6ff24a5..6489dd3c1 100644 --- a/java/google/registry/dns/DnsModule.java +++ b/java/google/registry/dns/DnsModule.java @@ -24,7 +24,7 @@ import static google.registry.dns.PublishDnsUpdatesAction.PARAM_NUM_PUBLISH_LOCK import static google.registry.dns.PublishDnsUpdatesAction.PARAM_PUBLISH_TASK_ENQUEUED; import static google.registry.dns.PublishDnsUpdatesAction.PARAM_REFRESH_REQUEST_CREATED; import static google.registry.request.RequestParameters.extractEnumParameter; -import static google.registry.request.RequestParameters.extractOptionalIntParameter; +import static google.registry.request.RequestParameters.extractIntParameter; import static google.registry.request.RequestParameters.extractRequiredParameter; import static google.registry.request.RequestParameters.extractSetOfParameters; @@ -96,15 +96,13 @@ public abstract class DnsModule { @Provides @Parameter(PARAM_LOCK_INDEX) static int provideLockIndex(HttpServletRequest req) { - // TODO(b/72150053): Make non-optional once this cl has reached production for an hour - return extractOptionalIntParameter(req, PARAM_LOCK_INDEX).orElse(1); + return extractIntParameter(req, PARAM_LOCK_INDEX); } @Provides @Parameter(PARAM_NUM_PUBLISH_LOCKS) static int provideMaxNumLocks(HttpServletRequest req) { - // TODO(b/72150053): Make non-optional once this cl has reached production for an hour - return extractOptionalIntParameter(req, PARAM_NUM_PUBLISH_LOCKS).orElse(1); + return extractIntParameter(req, PARAM_NUM_PUBLISH_LOCKS); } @Provides