mirror of
https://github.com/google/nomulus
synced 2026-09-05 23:57:01 +00:00
Change new authorization logic to log a warning rather than rejecting the request
This is the first step in rolling out the changes so that we can check via logging whether turning on the logic would reject anything it should not. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149050878
This commit is contained in:
@@ -48,6 +48,7 @@ import javax.servlet.http.HttpServletRequest;
|
||||
import javax.servlet.http.HttpServletResponse;
|
||||
import org.junit.After;
|
||||
import org.junit.Before;
|
||||
import org.junit.Ignore;
|
||||
import org.junit.Rule;
|
||||
import org.junit.Test;
|
||||
import org.junit.runner.RunWith;
|
||||
@@ -426,6 +427,8 @@ public final class RequestHandlerTest {
|
||||
verify(usersOnlyAction).run();
|
||||
}
|
||||
|
||||
// TODO(b/28219927): turn this on once we actually do authorization
|
||||
@Ignore
|
||||
@Test
|
||||
public void testNoAuthNeeded_success() throws Exception {
|
||||
when(req.getMethod()).thenReturn("GET");
|
||||
@@ -436,6 +439,8 @@ public final class RequestHandlerTest {
|
||||
assertThat(providedAuthResult.userAuthInfo()).isAbsent();
|
||||
}
|
||||
|
||||
// TODO(b/28219927): turn this on once we actually do authorization
|
||||
@Ignore
|
||||
@Test
|
||||
public void testAuthNeeded_notLoggedIn() throws Exception {
|
||||
when(req.getMethod()).thenReturn("GET");
|
||||
@@ -445,6 +450,8 @@ public final class RequestHandlerTest {
|
||||
assertThat(providedAuthResult).isNull();
|
||||
}
|
||||
|
||||
// TODO(b/28219927): turn this on once we actually do authorization
|
||||
@Ignore
|
||||
@Test
|
||||
public void testAuthNeeded_notAuthorized() throws Exception {
|
||||
userService.setUser(testUser, false);
|
||||
@@ -455,6 +462,8 @@ public final class RequestHandlerTest {
|
||||
assertThat(providedAuthResult).isNull();
|
||||
}
|
||||
|
||||
// TODO(b/28219927): turn this on once we actually do authorization
|
||||
@Ignore
|
||||
@Test
|
||||
public void testAuthNeeded_success() throws Exception {
|
||||
userService.setUser(testUser, true);
|
||||
|
||||
Reference in New Issue
Block a user