mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-19 06:32:00 +00:00
Code Issues Releases Wiki Activity

Make createBillingCostTransitions not null (#2405)

Browse Source 
* Make createBillingCostTransitions not null

* Set up createBillingCost field to be removed form config files

* Add clarifying comment
This commit is contained in:
sarahcaseybot
2024-04-23 18:22:45 +00:00
committed by GitHub
parent e809e967a3
commit f729802094
26 changed files with 115 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
db/src/main/resources/sql/er_diagram/brief_er_diagram.html
+7 -7
View File
@@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2024-03-28 21:10:10.784013213</td>
<td class="property_value">2024-04-17 19:49:33.30624492</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V166__drop_should_publish_column.sql</td>
<td id="lastFlywayFile" class="property_value">V167__creat_billing_cost_transitions_not_null.sql</td>
</tr>
</tbody>
</table>
@@ -277,11 +277,11 @@ td.section {
SchemaCrawler_Diagram
</title>
<polygon fill="white" stroke="transparent" points="-4,4 -4,-3493.5 4025,-3493.5 4025,4 -4,4" />
<text text-anchor="start" x="3730.5" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated by</text>
<text text-anchor="start" x="3813.5" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">SchemaCrawler 16.10.1</text>
<text text-anchor="start" x="3729.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated on</text>
<text text-anchor="start" x="3813.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">2024-03-28 21:10:10.784013213</text>
<polygon fill="none" stroke="#888888" points="3726,-4 3726,-44 4013,-44 4013,-4 3726,-4" /> <!-- allocationtoken_a08ccbef -->
<text text-anchor="start" x="3737" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated by</text>
<text text-anchor="start" x="3820" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">SchemaCrawler 16.10.1</text>
<text text-anchor="start" x="3736" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated on</text>
<text text-anchor="start" x="3820" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">2024-04-17 19:49:33.30624492</text>
<polygon fill="none" stroke="#888888" points="3733,-4 3733,-44 4013,-44 4013,-4 3733,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
<title>
allocationtoken_a08ccbef
db/src/main/resources/sql/er_diagram/full_er_diagram.html
+9 -9
View File
@@ -261,11 +261,11 @@ td.section {
</tr>
<tr>
<td class="property_name">generated on</td>
<td class="property_value">2024-03-28 21:10:08.34519385</td>
<td class="property_value">2024-04-17 19:49:29.701469664</td>
</tr>
<tr>
<td class="property_name">last flyway file</td>
<td id="lastFlywayFile" class="property_value">V166__drop_should_publish_column.sql</td>
<td id="lastFlywayFile" class="property_value">V167__creat_billing_cost_transitions_not_null.sql</td>
</tr>
</tbody>
</table>
@@ -277,11 +277,11 @@ td.section {
SchemaCrawler_Diagram
</title>
<polygon fill="white" stroke="transparent" points="-4,4 -4,-9310 4738,-9310 4738,4 -4,4" />
<text text-anchor="start" x="4450" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated by</text>
<text text-anchor="start" x="4533" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">SchemaCrawler 16.10.1</text>
<text text-anchor="start" x="4449" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated on</text>
<text text-anchor="start" x="4533" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">2024-03-28 21:10:08.34519385</text>
<polygon fill="none" stroke="#888888" points="4446,-4 4446,-44 4726,-44 4726,-4 4446,-4" /> <!-- allocationtoken_a08ccbef -->
<text text-anchor="start" x="4443.5" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated by</text>
<text text-anchor="start" x="4526.5" y="-29.8" font-family="Helvetica,sans-Serif" font-size="14.00">SchemaCrawler 16.10.1</text>
<text text-anchor="start" x="4442.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">generated on</text>
<text text-anchor="start" x="4526.5" y="-10.8" font-family="Helvetica,sans-Serif" font-size="14.00">2024-04-17 19:49:29.701469664</text>
<polygon fill="none" stroke="#888888" points="4439,-4 4439,-44 4726,-44 4726,-4 4439,-4" /> <!-- allocationtoken_a08ccbef -->
<g id="node1" class="node">
<title>
allocationtoken_a08ccbef
@@ -1626,7 +1626,7 @@ td.section {
<text text-anchor="start" x="1639" y="-3319.3" font-family="Helvetica,sans-Serif" font-size="14.00">timestamptz</text>
<text text-anchor="start" x="1360" y="-3300.3" font-family="Helvetica,sans-Serif" font-size="14.00">create_billing_cost_transitions</text>
<text text-anchor="start" x="1631" y="-3300.3" font-family="Helvetica,sans-Serif" font-size="14.00"> </text>
<text text-anchor="start" x="1639" y="-3300.3" font-family="Helvetica,sans-Serif" font-size="14.00">"hstore"</text>
<text text-anchor="start" x="1639" y="-3300.3" font-family="Helvetica,sans-Serif" font-size="14.00">"hstore" not null</text>
<polygon fill="none" stroke="#888888" points="1356.5,-3294 1356.5,-4189 1763.5,-4189 1763.5,-3294 1356.5,-3294" />
</g> <!-- domain_6c51cffa&#45;&gt;tld_f1fa57e2 -->
<g id="edge83" class="edge">
@@ -12871,7 +12871,7 @@ td.section {
<tr>
<td class="spacer"></td>
<td class="minwidth">create_billing_cost_transitions</td>
<td class="minwidth">"hstore"</td>
<td class="minwidth">"hstore" not null</td>
</tr>
<tr>
<td colspan="3"></td>
db/src/main/resources/sql/flyway.txt
+1
View File
@@ -164,3 +164,4 @@ V163__rename_console_registrar_history_time.sql
V164__rename_console_user_history_time.sql
V165__add_domain_repo_id_indexes_to_more_tables.sql
V166__drop_should_publish_column.sql
V167__creat_billing_cost_transitions_not_null.sql
db/src/main/resources/sql/flyway/V167__creat_billing_cost_transitions_not_null.sql
+18
View File
@@ -0,0 +1,18 @@
-- Copyright 2024 The Nomulus Authors. All Rights Reserved.
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
-- http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.
-- Note: we drop the not-null constraints from the history tables but we keep them in the
-- EPP resource tables since nothing inserted there should be null
ALTER TABLE "Tld" ALTER COLUMN create_billing_cost_transitions SET NOT NULL;
db/src/main/resources/sql/schema/db-schema.sql.generated
+1 -1
View File
@@ -739,7 +739,7 @@
claims_period_end timestamptz not null,
create_billing_cost_amount numeric(19, 2),
create_billing_cost_currency text,
create_billing_cost_transitions hstore,
create_billing_cost_transitions hstore not null,
creation_time timestamptz not null,
currency text not null,
default_promo_tokens text[],
db/src/main/resources/sql/schema/nomulus.golden.sql
+1 -1
View File
@@ -1286,7 +1286,7 @@ CREATE TABLE public."Tld" (
idn_tables text[],
breakglass_mode boolean DEFAULT false NOT NULL,
bsa_enroll_start_time timestamp with time zone,
create_billing_cost_transitions public.hstore
create_billing_cost_transitions public.hstore NOT NULL
);