Roll back changelist 180942763

*** Reason for rollback ***

Breaks the FOSS build.

We'll reincorporate this change once Closure Rules is properly updated to accommodate it.

*** Original change description ***

Change all foreach loops in Soy templates to use the for loop syntax

Soy supports 2 kinds of loops:
foreach- for iterating over items in a collection  e.g. {foreach $item in $list}...{/foreach}
for - for indexed iteration  e.g. {for $i in range(0, 10)}...{/for}

The reason Soy has 2 different loops is an accident of history, Soy didn’t use to have a proper grammar for expressions and so the alternate ‘for...range’ syntax was added to make it possible to write indexed loops.  As the gramma...

***

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=180961695

java/google/registry/ui/soy/BUILD

@@ -10,9 +10,6 @@ closure_js_template_library(
     name = "soy",
     srcs = glob(["*.soy"]),
     globals = "//java/google/registry/ui:globals.txt",
-    # TODO: remove this when upgrading rules closure.  This is only necessary because
-    # our version of soy is newer than what rules closure expects
-    should_generate_js_doc = False,
 )
 
 closure_java_template_library(