mirror of
https://github.com/google/nomulus
synced 2026-08-22 07:06:10 +00:00
Ben McIlwainandGitHub
cd65a4c9d8
- pr-polisher: Relaxed the package-lock.json strictness. If package.json or dependencies.gradle are modified, changes to package-lock.json now correctly trigger a WARNING rather than a fatal ERROR, streamlining intentional dependency updates. - java-ast-refactoring: Replaced the reliance on a local google-java-format binary with the project's native ./gradlew javaIncrementalFormatApply task for post-AST format fixes. - Updated GEMINI.md and skill instructions to explicitly authorize and mandate the agent to proactively propose systemic infrastructure fixes to the user when it encounters recurring friction, false positives, or brittle workarounds. - Overhauled the PR polisher "When to Use" instructions in GEMINI.md and SKILL.md into a critical mandate explicitly tying the execution of the polisher to the action of making or amending a commit to prevent agent forgetfulness.
3.0 KiB
3.0 KiB
name, description
| name | description |
|---|---|
| java-ast-refactoring | AST-aware Java refactoring using OpenRewrite. Use when asked to structurally refactor Java code, change class names, change method signatures/overloads, replace builder patterns, modify annotations, or perform cross-file structural replacements. Note: Renaming fields or local variables/parameters is not supported natively via simple YAML recipes in the standard openrewrite modules. |
AST-Aware Java Refactoring
This skill uses OpenRewrite to perform Abstract Syntax Tree (AST) based refactoring on Java codebases. This is highly preferred over text-based regex or python scripts because it understands Java semantics, correctly updates imports, and preserves formatting.
Parameter and Field Renaming (Last Resort)
Because OpenRewrite's YAML recipes do not natively support simple variable or field renaming, a custom script is provided:
python3 .gemini/skills/java-ast-refactoring/scripts/safe_rename.py <filepath> <old_name> <new_name>
CRITICAL: Running this python script is a LAST RESORT. It is a regex-based token replacement that ignores strings and comments, but it lacks true AST understanding. ALWAYS prefer using OpenRewrite recipes (rewrite.yml) for structural changes like renaming classes, methods, or moving targets, as OpenRewrite correctly handles imports, types, and cross-file references safely.
Usage
- Create a
rewrite.ymlrecipe file in the workspace root. Refer to.gemini/skills/java-ast-refactoring/references/rewrite_recipes.mdfor syntax. - Execute the script:
./.gemini/skills/java-ast-refactoring/scripts/run_rewrite.sh rewrite.yml
- The script will safely apply the AST transformations and then automatically run
./gradlew spotlessApplyand./gradlew javaIncrementalFormatApplyon the modified files to automatically fix any Checkstyle line-length and import ordering issues caused by longer/shorter identifiers. Verify the output usinggit diff. - MANDATORY: Always run
./gradlew build -x test(or the equivalent compile task) after running OpenRewrite to ensure no compilation errors were introduced.
Known Limitations & Troubleshooting
- Static Imports Dropped on Class Rename: When using
ChangeTypeto rename a class, OpenRewrite may sometimes drop static imports for fields/constants belonging to the old class instead of updating them to the new class. If compilation fails due to "cannot find symbol" for a constant after a class rename, manually restore the static import (e.g.,import static com.new.ClassName.CONSTANT;). - Continuous Improvement: If any new issues or edge cases are found while running the refactoring (e.g., build failures, formatting issues, or missed transformations), you MUST proactively ask the user if you should permanently update this skill file (
SKILL.md) and its accompanying scripts (scripts/run_rewrite.sh,scripts/safe_rename.py) to fix the issue for future use. Do not wait for the user to prompt you to fix the infrastructure.