mirror of
https://github.com/google/nomulus
synced 2026-05-21 23:31:51 +00:00
56fe588b56
This completes the exhaustive refactoring of foundational temporal types from Joda-Time to the native java.time API across the entire codebase. - Replaced org.joda.time.DateTime, Instant, LocalDate, and Duration with java.time equivalents. - Audited and updated Clock implementations (FakeClock, SystemClock). Added nowMillis(), nowDate(), and nowDateTime() to eliminate repetitive conversions and maintain parallel naming. - Replaced ZonedDateTime with OffsetDateTime globally per go/avoid-zdt. OffsetDateTime is a better fit as we use a hardcoded ZoneOffset.UTC throughout the system, making geographical time zone rules (like daylight saving time) irrelevant and preventing serialization ambiguities. Added a presubmit check. - Completely removed all transitional bridge methods from DateTimeUtils and deleted obsolete converters (e.g., DateTimeConverter). - Updated testing infrastructure, Apache Beam pipelines, custom JCommander parameters, and networking modules to solely rely on java.time primitives. - Retained the lone necessary org.joda.time.Instant usage in SafeBrowsingTransforms required by the Apache Beam API. - Cleared Gradle lockfiles and removed the joda-time dependency entirely from the build configuration.
40 lines
1.3 KiB
Java
40 lines
1.3 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.util;
|
|
|
|
import static java.time.temporal.ChronoUnit.MILLIS;
|
|
|
|
import jakarta.inject.Inject;
|
|
import java.time.Instant;
|
|
import javax.annotation.concurrent.ThreadSafe;
|
|
|
|
/** Clock implementation that proxies to the real system clock. */
|
|
@ThreadSafe
|
|
public class SystemClock implements Clock {
|
|
|
|
private static final long serialVersionUID = 5165372013848947515L;
|
|
|
|
@Inject
|
|
public SystemClock() {}
|
|
|
|
@Override
|
|
public Instant now() {
|
|
// Truncate to milliseconds to match the precision of our database schema.
|
|
// This prevents subtle comparison bugs where a high-precision Instant would be
|
|
// considered "after" a truncated database timestamp.
|
|
return Instant.now().truncatedTo(MILLIS);
|
|
}
|
|
}
|