gbrodmanandBen McIlwain 3cf26ff9b6 Fix various Error Prone errors that were found by the FOSS build ...

Most common:
- Unnecessary parentheses and operator precedence clarify (self-explanatory)
- Reference equality--there were a few instances of using == or != improperly
- Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to
- Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable
- String.split() having "surprising behavior"

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=230971531

2019-01-28 16:05:09 -05:00

..

mapreduce

Fix various Error Prone errors that were found by the FOSS build

2019-01-28 16:05:09 -05:00

sftp

[CL 2 of 3] Update apache mina library from v1_6_0 to v2_1_0

2018-10-08 16:59:29 -04:00

testdata

Refactor RdeKeyringModule into FakeKeyringModule

2017-03-21 14:53:25 -04:00

AbstractDomainBaseSubject.java

Merge DomainResource into DomainBase

2019-01-28 15:57:10 -05:00

AbstractEppResourceSubject.java

Migrate callers of Truth's Subject.failWithRawMessage to Subject.failWithoutActual

2018-08-10 13:44:25 -04:00

AppEngineAdminApiHelper.java

Add option --non_live_versions to set_num_instances command

2018-12-03 18:58:05 -05:00

AppEngineRule.java

Add debug logging to AppEngineRule

2019-01-18 17:29:11 -05:00

BouncyCastleProviderRule.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

BUILD

Add option --non_live_versions to set_num_instances command

2018-12-03 18:58:05 -05:00

CertificateSamples.java

Fix a few stylistic issues in preparation for Checkstyle addition

2019-01-24 19:57:14 -05:00

ContactResourceSubject.java

Replace FailureStrategy with FailureMetadata in gtld's Subjects

2017-11-21 18:39:45 -05:00

DatastoreHelper.java

Fix various Error Prone errors that were found by the FOSS build

2019-01-28 16:05:09 -05:00

default_premium_list_testdata.csv

Add premium support to nomulus create_domain command

2018-06-06 15:11:44 -04:00

DeterministicStringGenerator.java

Create GenerateAllocationTokens nomulus tool command

2018-01-19 14:26:56 -05:00

DomainBaseSubject.java

Merge DomainResource into DomainBase

2019-01-28 15:57:10 -05:00

EppExceptionSubject.java

Refactor EppXmlTransformer to be in the model/ package

2018-12-12 13:22:34 -05:00

EppLoader.java

Refactor EppXmlTransformer to be in the model/ package

2018-12-12 13:22:34 -05:00

EppMetricSubject.java

Stop exporting EPP flow metrics to BigQuery

2018-10-08 16:59:29 -04:00

FailAnswer.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

FakeClock.java

Make our Clock util Serializable

2018-06-27 15:28:52 -04:00

FakeHttpSession.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

FakeJsonResponse.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

FakeKeyringModule.java

Remove the ability to download service account credentials

2018-12-05 16:00:51 -05:00

FakeLockHandler.java

Create an injectable LockHandler

2017-09-12 15:51:50 -04:00

FakeOAuthService.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

FakeResponse.java

Send a plaintext link to the mapreduce console in fluent style

2019-01-10 17:14:06 -05:00

FakeServletInputStream.java

Fix various Error Prone errors that were found by the FOSS build

2019-01-28 16:05:09 -05:00

FakeServletOutputStream.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

FakeSleeper.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

FakeURLFetchService.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

FakeUserService.java

Daggerize XsrfTokenManager

2017-02-22 11:43:10 -05:00

ForwardingURLFetchService.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

FullFieldsTestEntityHelper.java

Merge DomainResource into DomainBase

2019-01-28 15:57:10 -05:00

GcsTestingUtils.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GenericEppResourceSubject.java

Replace FailureStrategy with FailureMetadata in gtld's Subjects

2017-11-21 18:39:45 -05:00

GoldenFileTestHelper.java

Add the App Engine service used in the Action definition

2019-01-17 18:59:16 -05:00

GpgSystemCommandRule.java

Fix bugs exposed by testing with Gradle

2018-10-17 11:44:41 -04:00

HistoryEntrySubject.java

Add an unrenew_domain command to nomulus tool

2018-12-12 13:22:34 -05:00

HostResourceSubject.java

Merge DomainResource into DomainBase

2019-01-28 15:57:10 -05:00

InjectRule.java

Remove references to Eclipse

2018-03-19 18:45:41 -04:00

Lazies.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

logging.properties

Rename Java packages to use the .google TLD

2016-05-13 20:04:42 -04:00

LogsSubject.java

Remove unnecessary type specifications

2017-12-27 11:23:03 -05:00

MockitoJUnitRule.java

Migrate away fully from MockitoJUnitRunner

2018-04-10 17:01:04 -04:00

package-info.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ReflectiveFieldExtractor.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ShardableTestCase.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

SlurpAnswer.java

Remove unnecessary "throws" declarations

2018-06-18 18:17:56 -04:00

SystemInfo.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

SystemPropertyRule.java

Restore original System Properties after tests

2018-11-14 11:57:23 -05:00

TaskQueueHelper.java

Remove more unnecessary "throws" declarations

2018-06-27 15:28:52 -04:00

TestCacheRule.java

Define TestRule that manages cache use in tests

2019-01-11 11:50:33 -05:00

TestDataHelper.java

Fix bugs exposed by testing with Gradle

2018-10-17 11:44:41 -04:00

TestLogHandlerUtils.java

Add asynchronous scheduled actions to re-save entities

2018-06-27 15:28:52 -04:00

TestObject.java

Add @VirtualEntity checking to Ofy's deleteWithoutBackup()

2017-02-08 17:31:07 -05:00

TruthChainer.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UriParameters.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UserInfo.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00