mirror of
https://github.com/google/nomulus
synced 2026-01-08 23:23:32 +00:00
537a6e4466
* Fix issues with saving and deleting gap records Datastore limits us to mutating up to 25 records per transaction. We sometimes exceed that when deleting expired gap records. In addition, it is theoretically possible for us to accumulate enough continuous gap records to exceed this count while replaying the original transaction. Deal with deletion by breaking up the gap records to be deleted into a batch size that is small enough to be deleted transactionally (in practice, we don't much care about the transactionality but it doesn't seem like we can delete batches without it). Deal with the possibility of too many additions by always breaking out gap record storage and last transaction number updates into their own transaction(s) (separate from the replay of the original SQL transaction).