mirror of
https://github.com/google/nomulus
synced 2026-05-13 11:21:46 +00:00
74f9f5d478
This commit migrates the BSA, DNS, batch, and reporting packages from Joda-Time to java.time. Key changes include: - Updated Sleeper, Clock, and BigqueryUtils to use java.time types natively. - Refactored models like RdeRevision and Tld to eliminate redundant Joda conversions, utilizing new DateTimeUtils static utilities for LocalDate. - Improved test safety by replacing dynamic Instant.now() calls with static parsed constants. - Migrated temporal arithmetic in test suites to use DateTimeUtils convenience methods (plusDays, minusDays). - Updated BigqueryUtils serialization to preserve millisecond precision and formatting for large years, ensuring consistency with previous Joda behavior. - Enhanced code readability by converting long concatenated strings to Java text blocks in LordnLogTest. - Resolved environmental test failures in SyncRegistrarsSheetTest by synchronizing the FakeClock with the JPA extension. - Updated project engineering standards (GEMINI.md) to prefer Truth's .hasValue() for Optional assertions. Verified with a clean full build and all relevant test suites passing.
49 lines
1.6 KiB
Java
49 lines
1.6 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.util;
|
|
|
|
import static java.time.temporal.ChronoUnit.MILLIS;
|
|
import static org.joda.time.DateTimeZone.UTC;
|
|
|
|
import jakarta.inject.Inject;
|
|
import java.time.Instant;
|
|
import javax.annotation.concurrent.ThreadSafe;
|
|
import org.joda.time.DateTime;
|
|
|
|
/** Clock implementation that proxies to the real system clock. */
|
|
@ThreadSafe
|
|
public class SystemClock implements Clock {
|
|
|
|
private static final long serialVersionUID = 5165372013848947515L;
|
|
|
|
@Inject
|
|
public SystemClock() {}
|
|
|
|
/** Returns the current time. */
|
|
@Override
|
|
public DateTime nowUtc() {
|
|
return DateTime.now(UTC);
|
|
}
|
|
|
|
@Override
|
|
public Instant now() {
|
|
// Truncate to milliseconds to match the precision of Joda DateTime and our database schema
|
|
// (which uses millisecond precision via DateTimeConverter). This prevents subtle comparison
|
|
// bugs where a high-precision Instant would be considered "after" a truncated database
|
|
// timestamp.
|
|
return Instant.now().truncatedTo(MILLIS);
|
|
}
|
|
}
|