mirror of
https://github.com/google/nomulus
synced 2026-03-27 04:45:14 +00:00
We have a restriction in our system that registrar display names be unique (as the display name is how registrars are queried through RDAP). And, the uniqueness constraint is enforced on the canonicalized version of the display name (with spaces and non alphanumeric characters removed). However, in the check enforcing this uniqueness, we were incorrectly checking against the existing saved entity of the same registrar, meaning that you couldn't update the display name of a single registrar to a new value that canonicalized the same (you would instead have to rename it to something else first that doesn't canonicalize the same, and then afterwards to the new desired value). That didn't make sense, so now we exclude the existing registrar entity from consideration when checking if there are conflicts.