guyben 9d2b1e7572 Consolidate all Set parameter parsing ...

Currently, we have two different ways to parse a "set" parameter:
key=value1&key=value2&key=value3...
and
keys=value1,value2,value3

This is error prone for several reasons:
- different parts of the code must be "synchronized" to use the same style (the
  place that creates the request, and the place that parses the request)
- for the key=value1&key=value2, we often use the same key name for the single
  value and the set value. This can result in subtle bugs where part of the
  code will successfully read the key assuming there's only one key (and will
  get the first key=value1, ignoring the rest)

Here we transition everything to the keys=value1,value2,value3 method. This one
was chosen because:
- it's shorter
- it's more intuitive for users
- the key name is plural, differentiating it from the singular key=value that
  other requests might need

-----------------------------------

To make sure there are not "transition issues", we will continue to support
(with warnings) the key=value1&key=value2 parameter parsing until we're sure we
haven't forgotten to update any part of the code.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=198810681

2018-06-06 15:04:02 -04:00

..

javascrap

Remove unnecessary explicit generic type declarations

2017-11-07 17:11:29 -05:00

params

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

resources

Add documentation about OAuth2 client id configuration

2017-07-12 11:03:50 -04:00

server

Consolidate all Set parameter parsing

2018-06-06 15:04:02 -04:00

soy

Merge the check_domain_fee nomulus command into check_domain

2018-05-30 12:18:54 -04:00

sql

Delete obsolete billing code

2018-02-20 15:09:45 -05:00

AllocateDomainCommand.java

Make async flow logic handle missing client transaction IDs

2018-05-05 23:21:55 -04:00

AppEngineConnection.java

Refactor Guava functional methods to use lambdas

2017-12-01 22:14:05 -05:00

AppEngineConnectionFlags.java

Add Client-side OAuth2 to HTTP connections

2017-02-17 12:17:53 -05:00

AuthModule.java

Make "throws" clause use IOException

2017-05-17 12:17:40 -04:00

BigqueryCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

BigqueryParameters.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

BUILD

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

CanonicalizeLabelsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CheckDomainClaimsCommand.java

Fix verb order in nomulus tool domain check commands

2018-04-10 17:04:07 -04:00

CheckDomainCommand.java

Merge the check_domain_fee nomulus command into check_domain

2018-05-30 12:18:54 -04:00

CheckSnapshotCommand.java

Refer to Datastore everywhere correctly by its capitalized form

2017-02-17 12:12:12 -05:00

Command.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

CommandRunner.java

Add a "shell" pseudo-command to nomulus tool

2018-03-19 18:22:01 -04:00

CommandUtilities.java

Fix CommandUtilities to fail gracefully if stdin is unavailable

2017-02-06 16:45:23 -05:00

ComparableEntity.java

Implement ComparableEntity class

2017-09-12 15:51:50 -04:00

CompareDbBackups.java

Implement compare_db_backups "main"

2017-09-20 10:27:17 -04:00

ConfirmingCommand.java

Add "Running ... " output to nomulus tool confirming commands

2018-04-23 15:04:04 -04:00

ConvertIdnCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CountDomainsCommand.java

Add nomulus count_domains command

2018-05-05 23:37:11 -04:00

CreateAnchorTenantCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CreateAuctionCreditsCommand.java

Replace com.google.common.base.Function with java.util.function.Function

2017-12-27 11:08:55 -05:00

CreateCdnsTld.java

Create prod Cloud DNS domains in prod zonespace

2018-04-10 16:20:52 -04:00

CreateContactCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CreateCreditBalanceCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

CreateCreditCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

CreateDomainCommand.java

Allow setting DS records in create_domain and update_domain

2018-02-05 23:56:16 -05:00

CreateHostCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CreateLrpTokensCommand.java

Replace many Work and VoidWork usages with lambdas

2017-11-21 18:45:12 -05:00

CreateOrUpdateDomainCommand.java

Allow setting DS records in create_domain and update_domain

2018-02-05 23:56:16 -05:00

CreateOrUpdatePremiumListCommand.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

CreateOrUpdateRegistrarCommand.java

Allow cert hash and fix array out of bound problem in OT&E command

2018-03-19 18:20:30 -04:00

CreateOrUpdateReservedListCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

CreateOrUpdateTldCommand.java

Clarify when to use cache (or not) when loading premium lists

2018-05-30 12:18:54 -04:00

CreatePremiumListCommand.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

CreateRegistrarCommand.java

Switch from Guava Optionals to Java 8 Optionals

2017-10-24 16:53:47 -04:00

CreateRegistrarGroupsCommand.java

Run automatic Java 8 conversion over codebase

2017-10-10 12:09:41 -04:00

CreateReservedListCommand.java

Refer to Datastore everywhere correctly by its capitalized form

2017-02-17 12:12:12 -05:00

CreateTldCommand.java

Remove unnecessary generic type arguments

2017-11-21 18:17:31 -05:00

DefaultRequestFactoryModule.java

Refactor Guava functional methods to use lambdas

2017-12-01 22:14:05 -05:00

DeleteCreditCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

DeleteDomainCommand.java

Add flag to delete domain immediately in nomulus too

2018-05-30 12:18:54 -04:00

DeleteEntityCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

DeleteHostCommand.java

Add delete_host nomulus tool command

2017-05-03 11:08:02 -04:00

DeletePremiumListCommand.java

Clarify when to use cache (or not) when loading premium lists

2018-05-30 12:18:54 -04:00

DeleteReservedListCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

DeleteTldCommand.java

Add nomulus tool command to delete a TLD

2017-04-05 10:10:38 -04:00

DeployInvoicingPipelineCommand.java

Add Dataflow path to generate overall monthly invoice

2017-12-13 12:43:45 -05:00

DomainApplicationInfoCommand.java

Don't prompt to confirm non-mutating nomulus EPP tool commands

2018-04-10 16:53:18 -04:00

EncryptEscrowDepositCommand.java

Make EncryptEscrowDepositCommand a RemoteApiCommand

2017-05-17 11:58:35 -04:00

EppToolCommand.java

Don't prompt to confirm non-mutating nomulus EPP tool commands

2018-04-10 16:53:18 -04:00

EscrowDepositEncryptor.java

Replace KeystoreKeyring with KmsKeystore comparison

2017-04-13 10:58:57 -04:00

ExecuteEppCommand.java

Fix two Gauava 20 deprecations across the tools package

2017-02-02 16:54:28 -05:00

GenerateAllocationTokensCommand.java

Create GenerateAllocationTokens nomulus tool command

2018-01-19 14:26:56 -05:00

GenerateApplicationsReportCommand.java

Make return value of ClaimsListShard.getClaimKey() Optional

2018-03-06 19:15:52 -05:00

GenerateAuctionDataCommand.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

GenerateDnsReportCommand.java

Refactor Guava functional methods to use lambdas

2017-12-01 22:14:05 -05:00

GenerateEscrowDepositCommand.java

Consolidate all Set parameter parsing

2018-06-06 15:04:02 -04:00

GenerateLordnCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GenerateZoneFilesCommand.java

Add assertTldsExist(Iterable<String>) to check multiple TLDs at once

2017-04-10 13:44:52 -04:00

GetApplicationCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetApplicationIdsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetAppliedLabelsCommand.java

Replace uses of X.to(Upper|Lower)Case() with Ascii.to(Upper|Lower)Case(X)

2018-04-23 15:02:31 -04:00

GetClaimsListCommand.java

Refer to Datastore everywhere correctly by its capitalized form

2017-02-17 12:12:12 -05:00

GetContactCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetDomainCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetEppResourceCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetHistoryEntriesCommand.java

Make async flow logic handle missing client transaction IDs

2018-05-05 23:21:55 -04:00

GetHostCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetKeyringSecretCommand.java

Add the ability to get_keyring_secret the public key from key pairs

2017-08-01 16:49:29 -04:00

GetLrpTokenCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetRegistrarCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

GetResourceByKeyCommand.java

Add command description to get_resource_by_key command

2017-03-13 10:41:15 -04:00

GetRoutingMapCommand.java

Add golden files for request component routing maps

2017-06-05 18:17:09 -04:00

GetSchemaCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

GetSchemaTreeCommand.java

Remove unnecessary generic type arguments

2017-11-21 18:17:31 -05:00

GetTldCommand.java

Add assertTldsExist(Iterable<String>) to check multiple TLDs at once

2017-04-10 13:44:52 -04:00

GhostrydeCommand.java

Replace KeystoreKeyring with KmsKeystore comparison

2017-04-13 10:58:57 -04:00

HashCertificateCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

HelpCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

Injector.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

LevelDbLogReader.java

Create a LevelDBLogReader class for java

2017-08-29 16:25:33 -04:00

ListCreditsCommand.java

Refactor Guava functional methods to use lambdas

2017-12-01 22:14:05 -05:00

ListCursorsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ListDomainsCommand.java

Add limit to list_domains command

2018-05-17 21:52:35 -04:00

ListHostsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ListObjectsCommand.java

Add limit to list_domains command

2018-05-17 21:52:35 -04:00

ListPremiumListsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ListRegistrarsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ListReservedListsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ListTldsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

LoadSnapshotCommand.java

Migrate Guava Predicates.notNull to Objects.nonNull

2017-12-27 11:19:53 -05:00

LoadTestCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

LockDomainCommand.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

LockOrUnlockDomainCommand.java

Add domain_lock nomulus command

2017-11-21 18:54:42 -05:00

logging.properties

Reduce console log spamminess in nomulus tool

2018-02-20 15:32:04 -05:00

LoggingParameters.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

LoginCommand.java

Fix nomulus tool NPEs on login/logout commands when printing usage

2017-03-13 10:35:23 -04:00

LogoutCommand.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

MutatingCommand.java

Replace com.google.common.base.Function with java.util.function.Function

2017-12-27 11:08:55 -05:00

MutatingEppToolCommand.java

Don't prompt to confirm non-mutating nomulus EPP tool commands

2018-04-10 16:53:18 -04:00

NonMutatingEppToolCommand.java

Don't prompt to confirm non-mutating nomulus EPP tool commands

2018-04-10 16:53:18 -04:00

package-info.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

PendingEscrowCommand.java

Replace com.google.common.base.Function with java.util.function.Function

2017-12-27 11:08:55 -05:00

RecordAccumulator.java

Create an entity record accumulator

2017-09-12 15:51:50 -04:00

RegistrarActivityReportCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

RegistrarContactCommand.java

Remove unnecessary Boolean boxing/unboxing

2017-11-07 17:08:35 -05:00

RegistryCli.java

Fix the shell to allow multiple mutation of the same entity

2018-04-10 17:08:45 -04:00

RegistryTool.java

Merge the check_domain_fee nomulus command into check_domain

2018-05-30 12:18:54 -04:00

RegistryToolComponent.java

Add nomulus count_domains command

2018-05-05 23:37:11 -04:00

RegistryToolEnvironment.java

Clean up some code quality issues

2017-12-01 22:14:06 -05:00

RegistryToolModule.java

Create GenerateAllocationTokens nomulus tool command

2018-01-19 14:26:56 -05:00

ResaveEntitiesCommand.java

Refer to Datastore everywhere correctly by its capitalized form

2017-02-17 12:12:12 -05:00

ResaveEnvironmentEntitiesCommand.java

Replace many Work and VoidWork usages with lambdas

2017-11-21 18:45:12 -05:00

ResaveEppResourceCommand.java

Refer to Datastore everywhere correctly by its capitalized form

2017-02-17 12:12:12 -05:00

RestoreCommitLogsCommand.java

Create nomulus tool restore command

2017-06-05 18:17:09 -04:00

SendEscrowReportToIcannCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ServerSideCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

SetupOteCommand.java

Allow cert hash and fix array out of bound problem in OT&E command

2018-03-19 18:20:30 -04:00

ShellCommand.java

Revert error message escaping to hand written version

2018-05-17 21:52:35 -04:00

UniformRapidSuspensionCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UnlockDomainCommand.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

UpdateApplicationStatusCommand.java

Replace many Work and VoidWork usages with lambdas

2017-11-21 18:45:12 -05:00

UpdateClaimsNoticeCommand.java

Replace many Work and VoidWork usages with lambdas

2017-11-21 18:45:12 -05:00

UpdateCursorsCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UpdateDomainCommand.java

Migrate to Flogger (green)

2018-05-30 12:18:54 -04:00

UpdateKmsKeyringCommand.java

Add the ability to get_keyring_secret the public key from key pairs

2017-08-01 16:49:29 -04:00

UpdatePremiumListCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UpdateRegistrarCommand.java

Make Registrar load methods return Optionals instead of Nullables

2017-08-01 16:58:59 -04:00

UpdateReservedListCommand.java

Switch from Guava Optionals to Java 8 Optionals

2017-10-24 16:53:47 -04:00

UpdateServerLocksCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UpdateSmdCommand.java

Replace many Work and VoidWork usages with lambdas

2017-11-21 18:45:12 -05:00

UpdateTldCommand.java

Remove unnecessary generic type arguments

2017-11-21 18:17:31 -05:00

UploadClaimsListCommand.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

UserIdProvider.java

Update copyright year on all license headers

2017-02-02 16:27:22 -05:00

ValidateEscrowDepositCommand.java

Run automatic Java 8 conversion over codebase

2017-10-10 12:09:41 -04:00

ValidateLoginCredentialsCommand.java

Switch from Guava Optionals to Java 8 Optionals

2017-10-24 16:53:47 -04:00

VerifyOteCommand.java

Change dash to underscore in param name for consistency

2018-04-02 16:36:50 -04:00

WhoisQueryCommand.java

Add ability to show full WHOIS output in nomulus command

2018-05-30 12:18:54 -04:00