mirror of
https://github.com/google/nomulus
synced 2026-08-16 04:06:09 +00:00
Lai JiangandGitHub
b5d2b56426
This PR makes it possible to build the Nomulus code base using Java 17. Building with Java 11 continue to be possible and the resulting bytecodes are still at Java 8 level. Also upgraded Gradle to 8.5. There are several necessary changes to make this happen: 1. Some Gradle plugins need to be upgraded to support Java 17, notably errorprone. As a result, a lot more "errors" were caught and corrected. 2. All test code are now built and run at Java 8 level. Previously it was left undefined (which defaults to the version of the compiler) and had led to situations where we inadvertently called Java 8+ features in production that are not caught by tests. The change also made the java8compatibility subproject obsolete, which is therefore removed. 3. Removed the docs subproject. Its main use is to generate flows.md, but it relies heavily on Java internal APIs that have changed significant with each version. Upgrading to Java 11 required extensive refactoring of the code there, and Java 17 again removed many APIs that were used. I don't think it is worth the maintenance effort just to have a tool to generate flows.md which no one actually reads. 4. Capped a few GCP dependencies because the latest version depends on grpc-java >= 1.59.0, which includes a runtime incompatibility (https://github.com/grpc/grpc-java/releases/tag/v1.59.0).
86 lines
3.4 KiB
Java
86 lines
3.4 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.util;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static java.nio.charset.StandardCharsets.UTF_8;
|
|
import static java.util.Arrays.asList;
|
|
import static org.junit.jupiter.api.Assertions.assertThrows;
|
|
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import java.io.ByteArrayOutputStream;
|
|
import java.io.OutputStream;
|
|
import org.junit.jupiter.api.Test;
|
|
|
|
/** Unit tests for {@link TeeOutputStream}. */
|
|
class TeeOutputStreamTest {
|
|
|
|
private final ByteArrayOutputStream outputA = new ByteArrayOutputStream();
|
|
private final ByteArrayOutputStream outputB = new ByteArrayOutputStream();
|
|
private final ByteArrayOutputStream outputC = new ByteArrayOutputStream();
|
|
|
|
@Test
|
|
void testWrite_writesToMultipleStreams() throws Exception {
|
|
// Write shared data using the tee output stream.
|
|
try (OutputStream tee = new TeeOutputStream(asList(outputA, outputB, outputC))) {
|
|
tee.write("hello ".getBytes(UTF_8));
|
|
tee.write("hello world!".getBytes(UTF_8), 6, 5);
|
|
tee.write('!');
|
|
}
|
|
// Write some more data to the different streams - they should not have been closed.
|
|
outputA.write("a".getBytes(UTF_8));
|
|
outputB.write("b".getBytes(UTF_8));
|
|
outputC.write("c".getBytes(UTF_8));
|
|
// Check the results.
|
|
// TODO: Use toString(StandardCharsets.UTF_8) once we can use Java 17.
|
|
assertThat(outputA.toString("UTF-8")).isEqualTo("hello world!a");
|
|
assertThat(outputB.toString("UTF-8")).isEqualTo("hello world!b");
|
|
assertThat(outputC.toString("UTF-8")).isEqualTo("hello world!c");
|
|
}
|
|
|
|
@Test
|
|
@SuppressWarnings("resource")
|
|
void testConstructor_failsWithEmptyIterable() {
|
|
assertThrows(IllegalArgumentException.class, () -> new TeeOutputStream(ImmutableSet.of()));
|
|
}
|
|
|
|
@Test
|
|
void testWriteInteger_failsAfterClose() throws Exception {
|
|
OutputStream tee = new TeeOutputStream(ImmutableList.of(outputA));
|
|
tee.close();
|
|
IllegalStateException thrown = assertThrows(IllegalStateException.class, () -> tee.write(1));
|
|
assertThat(thrown).hasMessageThat().contains("outputstream closed");
|
|
}
|
|
|
|
@Test
|
|
void testWriteByteArray_failsAfterClose() throws Exception {
|
|
OutputStream tee = new TeeOutputStream(ImmutableList.of(outputA));
|
|
tee.close();
|
|
IllegalStateException thrown =
|
|
assertThrows(IllegalStateException.class, () -> tee.write("hello".getBytes(UTF_8)));
|
|
assertThat(thrown).hasMessageThat().contains("outputstream closed");
|
|
}
|
|
|
|
@Test
|
|
void testWriteByteSubarray_failsAfterClose() throws Exception {
|
|
OutputStream tee = new TeeOutputStream(ImmutableList.of(outputA));
|
|
tee.close();
|
|
IllegalStateException thrown =
|
|
assertThrows(IllegalStateException.class, () -> tee.write("hello".getBytes(UTF_8), 1, 3));
|
|
assertThat(thrown).hasMessageThat().contains("outputstream closed");
|
|
}
|
|
}
|