mirror of
https://github.com/google/nomulus
synced 2026-01-11 00:10:36 +00:00
c5aa0125ab
* Implement DatastoreEntity and SqlEntity on more classes For classes that aren't going to transition to SQL, they should just return an empty list of SqlEntities. When reading these in from the commit log manifests, we just won't persist anything to SQL. By having all Datastore entity classes implement DatastoreEntity, we can avoid potential bugs where we forget to transition some entity to SQL, or we forget to have the capability to read back from the commit logs. Note: the EntityTest is still @Ignore'd because there are many SQL and Datastore classes left -- ones that we are still in the process of converting or adding, or ones that require more complicated transitions. Note: Locks and Cursors aren't converted (even though we could) because they're ephemeral * Responses to CR Add a @EntityForTest annotation fix null that snuck in * Keep the test ignored for now