mirror of
https://github.com/google/nomulus
synced 2026-05-30 19:46:34 +00:00
c5abd2a7c9
This commit relaxes the upper bounds on several dependencies that were previously hardcapped to specific versions: - com.google.protobuf to [3.25.5,) and [3.17.3,) - org.apache.beam to [2.72.0,) - io.github.ss-bhatt to [1.0.0,) - io.protostuff to [1.8.0,) - redis.clients:jedis to [7.4.1,) - org.junit.jupiter and org.junit.platform to [5.6.2,) and [1.6.2,) - org.jcommander to [2.0,) - org.jline to [3.0,) - jakarta.servlet to [6.0,) Upgrading to the modern versions of jline introduced a breaking change where DefaultParser().parse(line, line.length()) strips trailing spaces when using the default ParseContext.UNSPECIFIED. This caused the autocompletion to misbehave and tests to fail. This commit fixes ShellCommandTest.java by explicitly passing ParseContext.COMPLETE when parsing test strings to perfectly mimic the real-world JLine completion context. Additionally, SqlIntegrationTestSuite was migrated to JUnit 5's @Suite annotation, fixing a NoClassDefFoundError introduced by uncapping the JUnit Platform dependencies, and the test suite was re-integrated into the standard :build lifecycle. The following dependencies remain explicitly capped: 1. Hibernate & Jakarta Persistence (Blocked by -Werror): These are held back because newer Jakarta Persistence versions deprecate executeUpdate(), setMaxResults(), and getResultStream() on Query. - org.hibernate.orm:hibernate-core:7.3.4.Final - org.hibernate.orm:hibernate-hikaricp:7.3.4.Final - org.hibernate.orm:hibernate-ant:7.3.4.Final - jakarta.persistence:jakarta.persistence-api:[3.2.0,4.0.0) 2. Netty (Blocked by abandoned v5): Netty 5.0.0 was an experimental release abandoned in 2015. We explicitly cap beneath 5.0.0 so Gradle doesn't resolve dead-end alphas. - io.netty:netty-codec-http:[4.1.59.Final, 5.0.0)!! - io.netty:netty-codec:[4.1.59.Final, 5.0.0)!! - io.netty:netty-common:[4.1.59.Final, 5.0.0)!! - io.netty:netty-handler:[4.1.59.Final, 5.0.0)!! - io.netty:netty-transport:[4.1.59.Final, 5.0.0)!! - io.netty:netty-buffer:[4.1.59.Final, 5.0.0)!! 3. Google API Services: Capped beneath their respective unstable beta/v1b4 versions: - com.google.apis:google-api-services-dataflow:[v1b3-rev20240430-2.0.0, v1b4)!! - com.google.apis:google-api-services-dns:[v1-rev20240419-2.0.0, v2beta) The lockfiles have been fully regenerated and all test suites ran successfully against the latest available transitive versions.