mirror of
https://github.com/google/nomulus
synced 2026-05-20 23:01:53 +00:00
56fe588b56
This completes the exhaustive refactoring of foundational temporal types from Joda-Time to the native java.time API across the entire codebase. - Replaced org.joda.time.DateTime, Instant, LocalDate, and Duration with java.time equivalents. - Audited and updated Clock implementations (FakeClock, SystemClock). Added nowMillis(), nowDate(), and nowDateTime() to eliminate repetitive conversions and maintain parallel naming. - Replaced ZonedDateTime with OffsetDateTime globally per go/avoid-zdt. OffsetDateTime is a better fit as we use a hardcoded ZoneOffset.UTC throughout the system, making geographical time zone rules (like daylight saving time) irrelevant and preventing serialization ambiguities. Added a presubmit check. - Completely removed all transitional bridge methods from DateTimeUtils and deleted obsolete converters (e.g., DateTimeConverter). - Updated testing infrastructure, Apache Beam pipelines, custom JCommander parameters, and networking modules to solely rely on java.time primitives. - Retained the lone necessary org.joda.time.Instant usage in SafeBrowsingTransforms required by the Apache Beam API. - Cleared Gradle lockfiles and removed the joda-time dependency entirely from the build configuration.
69 lines
2.1 KiB
Groovy
69 lines
2.1 KiB
Groovy
// Copyright 2019 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
sourceSets {
|
|
testing {
|
|
java {
|
|
compileClasspath += main.output
|
|
runtimeClasspath += main.output
|
|
}
|
|
}
|
|
test {
|
|
java {
|
|
compileClasspath += testing.output
|
|
runtimeClasspath += testing.output
|
|
}
|
|
}
|
|
}
|
|
|
|
configurations {
|
|
// For reasons I don't understand, testingCompileOnly is the configuration
|
|
// used for compiling the classes in the "testing" jar.
|
|
testingCompileOnly.extendsFrom implementation
|
|
testingRuntimeOnly.extendsFrom runtimeOnly
|
|
|
|
testImplementation.extendsFrom testingCompile
|
|
testRuntimeOnly.extendsFrom testingRuntime
|
|
|
|
// All testing util classes. Other projects may declare dependency as:
|
|
// testImplementation project(path: 'common', configuration: 'testing')
|
|
create("testing")
|
|
testing.extendsFrom testingCompileOnly
|
|
}
|
|
|
|
task testingJar(type: Jar) {
|
|
archiveBaseName = 'testing'
|
|
from sourceSets.testing.output
|
|
}
|
|
|
|
artifacts {
|
|
testing testingJar
|
|
}
|
|
|
|
dependencies {
|
|
def deps = rootProject.dependencyMap
|
|
|
|
implementation deps['com.github.ben-manes.caffeine:caffeine']
|
|
implementation deps['com.google.code.findbugs:jsr305']
|
|
implementation deps['com.google.guava:guava']
|
|
implementation deps['jakarta.inject:jakarta.inject-api']
|
|
implementation deps['com.google.flogger:flogger']
|
|
implementation deps['io.github.java-diff-utils:java-diff-utils']
|
|
implementation deps['com.google.truth:truth']
|
|
|
|
testImplementation deps['org.junit.jupiter:junit-jupiter-api']
|
|
testImplementation deps['org.junit.jupiter:junit-jupiter-engine']
|
|
testImplementation deps['org.junit.platform:junit-platform-launcher']
|
|
}
|