mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rewrite logging in console (#788)

Browse Source 
- enhance logging throughout the codebase
- all packages at pkg/ should never log
  or perform log.Fatal() instead packages
  should return errors through functions.
- simplified various user, group mapping
  and removed redundant functions.
- deprecate older flags like --tls-certificate
  --tls-key and --tls-ca as we do not use
  them anymore, keep them for backward compatibility
  for some time.
This commit is contained in:
Harshavardhana
2021-06-04 11:35:55 -07:00
committed by GitHub
parent b65f04a2b5
commit 07fbb8b8f7
41 changed files with 456 additions and 507 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
restapi/user_objects.go
View File

@@ -20,7 +20,6 @@ import (
"context"
"fmt"
"io"
"log"
"net/http"
"path/filepath"
"regexp"
@@ -69,13 +68,8 @@ func registerObjectsHandlers(api *operations.ConsoleAPI) {
return user_api.NewDownloadObjectDefault(int(err.Code)).WithPayload(err)
}
return middleware.ResponderFunc(func(rw http.ResponseWriter, _ runtime.Producer) {
if _, err := io.Copy(rw, resp); err != nil {
log.Println(err)
} else {
if err := resp.Close(); err != nil {
log.Println(err)
}
}
io.Copy(rw, resp)
resp.Close()
})
})
// upload object
@@ -185,7 +179,7 @@ func listBucketObjects(ctx context.Context, client MinioClient, bucketName strin
if err != nil {
errResp := minio.ToErrorResponse(probe.NewError(err).ToGoError())
if errResp.Code != "InvalidRequest" && errResp.Code != "NoSuchObjectLockConfiguration" {
log.Printf("error getting legal hold status for %s : %s", lsObj.VersionID, err)
LogError("error getting legal hold status for %s : %v", lsObj.VersionID, err)
}
} else {
if legalHoldStatus != nil {
@@ -197,7 +191,7 @@ func listBucketObjects(ctx context.Context, client MinioClient, bucketName strin
if err != nil {
errResp := minio.ToErrorResponse(probe.NewError(err).ToGoError())
if errResp.Code != "NoSuchObjectLockConfiguration" {
log.Printf("error getting retention status for %s : %s", lsObj.VersionID, err)
LogError("error getting retention status for %s : %v", lsObj.VersionID, err)
}
} else {
if retention != nil && retUntilDate != nil {
@@ -208,7 +202,7 @@ func listBucketObjects(ctx context.Context, client MinioClient, bucketName strin
}
tags, err := client.getObjectTagging(ctx, bucketName, lsObj.Key, minio.GetObjectTaggingOptions{VersionID: lsObj.VersionID})
if err != nil {
log.Printf("error getting object tags for %s : %s", lsObj.VersionID, err)
LogError("error getting object tags for %s : %v", lsObj.VersionID, err)
} else {
obj.Tags = tags.ToMap()
}