mirrors/object-browser
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed HTTP verb to DELETE for DeleteMultipleServiceAccounts (#1526)

Browse Source
This commit is contained in:
jinapurapu
2022-02-07 19:51:40 -08:00
committed by GitHub
parent 7f05c0bf06
commit 090b7e5e26
7 changed files with 27 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
portal-ui/src/screens/Console/Users/DeleteMultipleServiceAccounts.tsx
View File

@@ -41,12 +41,12 @@ const DeleteMultipleSAs = ({
return null; return null;
} }
const onConfirmDelete = () => { const onConfirmDelete = () => {
invokeDeleteApi( invokeDeleteApi(
"POST", "DELETE",
`/api/v1/service-accounts/delete-multi`, `/api/v1/service-accounts/delete-multi`,
selectedSAs selectedSAs
); );
}; };
return ( return (
<ConfirmDialog <ConfirmDialog
title={`Delete Service Accounts`} title={`Delete Service Accounts`}

8
restapi/embedded_spec.go
View File

@@ -3063,7 +3063,7 @@ func init() {
} }
}, },
"/service-accounts/delete-multi": { "/service-accounts/delete-multi": {
"post": { "delete": {
"tags": [ "tags": [
"UserAPI" "UserAPI"
], ],
@@ -3083,7 +3083,7 @@ func init() {
} }
], ],
"responses": { "responses": {
"200": { "204": {
"description": "A successful response." "description": "A successful response."
}, },
"default": { "default": {
@@ -9172,7 +9172,7 @@ func init() {
} }
}, },
"/service-accounts/delete-multi": { "/service-accounts/delete-multi": {
"post": { "delete": {
"tags": [ "tags": [
"UserAPI" "UserAPI"
], ],
@@ -9192,7 +9192,7 @@ func init() {
} }
], ],
"responses": { "responses": {
"200": { "204": {
"description": "A successful response." "description": "A successful response."
}, },
"default": { "default": {

6
restapi/operations/console_api.go
View File

@@ -1277,10 +1277,10 @@ func (o *ConsoleAPI) initHandlerCache() {
o.handlers["POST"] = make(map[string]http.Handler) o.handlers["POST"] = make(map[string]http.Handler)
} }
o.handlers["POST"]["/buckets/{bucket_name}/delete-objects"] = user_api.NewDeleteMultipleObjects(o.context, o.UserAPIDeleteMultipleObjectsHandler) o.handlers["POST"]["/buckets/{bucket_name}/delete-objects"] = user_api.NewDeleteMultipleObjects(o.context, o.UserAPIDeleteMultipleObjectsHandler)
if o.handlers["POST"] == nil { if o.handlers["DELETE"] == nil {
o.handlers["POST"] = make(map[string]http.Handler) o.handlers["DELETE"] = make(map[string]http.Handler)
} }
o.handlers["POST"]["/service-accounts/delete-multi"] = user_api.NewDeleteMultipleServiceAccounts(o.context, o.UserAPIDeleteMultipleServiceAccountsHandler) o.handlers["DELETE"]["/service-accounts/delete-multi"] = user_api.NewDeleteMultipleServiceAccounts(o.context, o.UserAPIDeleteMultipleServiceAccountsHandler)
if o.handlers["DELETE"] == nil { if o.handlers["DELETE"] == nil {
o.handlers["DELETE"] = make(map[string]http.Handler) o.handlers["DELETE"] = make(map[string]http.Handler)
} }

2
restapi/operations/user_api/delete_multiple_service_accounts.go
View File

@@ -48,7 +48,7 @@ func NewDeleteMultipleServiceAccounts(ctx *middleware.Context, handler DeleteMul
return &DeleteMultipleServiceAccounts{Context: ctx, Handler: handler} return &DeleteMultipleServiceAccounts{Context: ctx, Handler: handler}
} }
/* DeleteMultipleServiceAccounts swagger:route POST /service-accounts/delete-multi UserAPI deleteMultipleServiceAccounts /* DeleteMultipleServiceAccounts swagger:route DELETE /service-accounts/delete-multi UserAPI deleteMultipleServiceAccounts
Delete Multiple Service Accounts Delete Multiple Service Accounts

20
restapi/operations/user_api/delete_multiple_service_accounts_responses.go
View File

@@ -30,28 +30,28 @@ import (
"github.com/minio/console/models" "github.com/minio/console/models"
) )
// DeleteMultipleServiceAccountsOKCode is the HTTP code returned for type DeleteMultipleServiceAccountsOK // DeleteMultipleServiceAccountsNoContentCode is the HTTP code returned for type DeleteMultipleServiceAccountsNoContent
const DeleteMultipleServiceAccountsOKCode int = 200 const DeleteMultipleServiceAccountsNoContentCode int = 204
/*DeleteMultipleServiceAccountsOK A successful response. /*DeleteMultipleServiceAccountsNoContent A successful response.
swagger:response deleteMultipleServiceAccountsOK swagger:response deleteMultipleServiceAccountsNoContent
*/ */
type DeleteMultipleServiceAccountsOK struct { type DeleteMultipleServiceAccountsNoContent struct {
} }
// NewDeleteMultipleServiceAccountsOK creates DeleteMultipleServiceAccountsOK with default headers values // NewDeleteMultipleServiceAccountsNoContent creates DeleteMultipleServiceAccountsNoContent with default headers values
func NewDeleteMultipleServiceAccountsOK() *DeleteMultipleServiceAccountsOK { func NewDeleteMultipleServiceAccountsNoContent() *DeleteMultipleServiceAccountsNoContent {
return &DeleteMultipleServiceAccountsOK{} return &DeleteMultipleServiceAccountsNoContent{}
} }
// WriteResponse to the client // WriteResponse to the client
func (o *DeleteMultipleServiceAccountsOK) WriteResponse(rw http.ResponseWriter, producer runtime.Producer) { func (o *DeleteMultipleServiceAccountsNoContent) WriteResponse(rw http.ResponseWriter, producer runtime.Producer) {
rw.Header().Del(runtime.HeaderContentType) //Remove Content-Type on empty responses rw.Header().Del(runtime.HeaderContentType) //Remove Content-Type on empty responses
rw.WriteHeader(200) rw.WriteHeader(204)
} }
/*DeleteMultipleServiceAccountsDefault Generic error response. /*DeleteMultipleServiceAccountsDefault Generic error response.

2
restapi/user_service_accounts.go
View File

@@ -104,7 +104,7 @@ func registerServiceAccountsHandlers(api *operations.ConsoleAPI) {
if err := getDeleteMultipleServiceAccountsResponse(session, params.SelectedSA); err != nil { if err := getDeleteMultipleServiceAccountsResponse(session, params.SelectedSA); err != nil {
return user_api.NewDeleteMultipleServiceAccountsDefault(int(err.Code)).WithPayload(err) return user_api.NewDeleteMultipleServiceAccountsDefault(int(err.Code)).WithPayload(err)
} }
return user_api.NewDeleteMultipleServiceAccountsOK() return user_api.NewDeleteMultipleServiceAccountsNoContent()
}) })
} }

4
swagger-console.yml
View File

@@ -1261,7 +1261,7 @@ paths:
- UserAPI - UserAPI
/service-accounts/delete-multi: /service-accounts/delete-multi:
post: delete:
summary: Delete Multiple Service Accounts summary: Delete Multiple Service Accounts
operationId: DeleteMultipleServiceAccounts operationId: DeleteMultipleServiceAccounts
parameters: parameters:
@@ -1273,7 +1273,7 @@ paths:
items: items:
type: string type: string
responses: responses:
200: 204:
description: A successful response. description: A successful response.
default: default:
description: Generic error response. description: Generic error response.