Added delete all replication rules capability (#1579)

This commit is contained in:
Alex
2022-02-15 18:14:23 -07:00
committed by GitHub
parent 00c4ba430d
commit 226e8eeef2
11 changed files with 641 additions and 38 deletions

View File

@@ -20,8 +20,6 @@ import { Theme } from "@mui/material/styles";
import createStyles from "@mui/styles/createStyles";
import withStyles from "@mui/styles/withStyles";
import Grid from "@mui/material/Grid";
import AddIcon from "../../../../icons/AddIcon";
import BucketsIcon from "../../../../icons/BucketsIcon";
import { setErrorSnackMessage } from "../../../../actions";
import {
actionsTray,
@@ -35,17 +33,16 @@ import {
} from "../types";
import { ErrorResponseHandler } from "../../../../common/types";
import { AppState } from "../../../../store";
import api from "../../../../common/api";
import TableWrapper from "../../Common/TableWrapper/TableWrapper";
import HelpBox from "../../../../common/HelpBox";
import PanelTitle from "../../Common/PanelTitle/PanelTitle";
import {
SecureComponent,
hasPermission,
} from "../../../../common/SecureComponent";
import { IAM_SCOPES } from "../../../../common/SecureComponent/permissions";
import { AddIcon, DeleteIcon, BucketsIcon } from "../../../../icons";
import api from "../../../../common/api";
import TableWrapper from "../../Common/TableWrapper/TableWrapper";
import HelpBox from "../../../../common/HelpBox";
import PanelTitle from "../../Common/PanelTitle/PanelTitle";
import withSuspense from "../../Common/Components/withSuspense";
import RBIconButton from "./SummaryItems/RBIconButton";
import EditReplicationModal from "./EditReplicationModal";
@@ -79,7 +76,6 @@ const BucketReplicationPanel = ({
match,
setErrorSnackMessage,
loadingBucket,
bucketInfo,
}: IBucketReplicationProps) => {
const [loadingReplication, setLoadingReplication] = useState<boolean>(true);
const [replicationRules, setReplicationRules] = useState<
@@ -91,6 +87,7 @@ const BucketReplicationPanel = ({
const [editReplicationModal, setEditReplicationModal] =
useState<boolean>(false);
const [selectedRRule, setSelectedRRule] = useState<string>("");
const [deleteAllRules, setDeleteAllRules] = useState<boolean>(false);
const bucketName = match.params["bucketName"];
@@ -159,6 +156,13 @@ const BucketReplicationPanel = ({
const confirmDeleteReplication = (replication: BucketReplicationRule) => {
setSelectedRRule(replication.id);
setDeleteAllRules(false);
setDeleteReplicationModal(true);
};
const confirmDeleteAllReplicationRules = () => {
setSelectedRRule("allRules");
setDeleteAllRules(true);
setDeleteReplicationModal(true);
};
@@ -179,7 +183,6 @@ const BucketReplicationPanel = ({
{
type: "delete",
onClick: confirmDeleteReplication,
disableButtonFunction: () => replicationRules.length === 1,
},
{
type: "view",
@@ -209,6 +212,8 @@ const BucketReplicationPanel = ({
selectedBucket={bucketName}
closeDeleteModalAndRefresh={closeReplicationModalDelete}
ruleToDelete={selectedRRule}
remainingRules={replicationRules.length}
deleteAllRules={deleteAllRules}
/>
)}
@@ -223,23 +228,43 @@ const BucketReplicationPanel = ({
<Grid container>
<Grid item xs={12} className={classes.actionsTray}>
<PanelTitle>Replication</PanelTitle>
<SecureComponent
scopes={[IAM_SCOPES.S3_PUT_REPLICATION_CONFIGURATION]}
resource={bucketName}
matchAll
errorProps={{ disabled: true }}
>
<RBIconButton
tooltip={"Add Replication Rule"}
onClick={() => {
setOpenReplicationOpen(true);
}}
text={"Add Replication Rule"}
icon={<AddIcon />}
color="primary"
variant={"contained"}
/>
</SecureComponent>
<div>
<SecureComponent
scopes={[IAM_SCOPES.S3_PUT_REPLICATION_CONFIGURATION]}
resource={bucketName}
matchAll
errorProps={{ disabled: true }}
>
<RBIconButton
tooltip={"Remove All Replication Rules"}
onClick={() => {
confirmDeleteAllReplicationRules();
}}
text={"Remove All Rules"}
icon={<DeleteIcon />}
color={"secondary"}
variant={"outlined"}
disabled={replicationRules.length === 0}
/>
</SecureComponent>
<SecureComponent
scopes={[IAM_SCOPES.S3_PUT_REPLICATION_CONFIGURATION]}
resource={bucketName}
matchAll
errorProps={{ disabled: true }}
>
<RBIconButton
tooltip={"Add Replication Rule"}
onClick={() => {
setOpenReplicationOpen(true);
}}
text={"Add Replication Rule"}
icon={<AddIcon />}
color="primary"
variant={"contained"}
/>
</SecureComponent>
</div>
</Grid>
<Grid item xs={12}>
<SecureComponent
@@ -284,6 +309,7 @@ const BucketReplicationPanel = ({
</SecureComponent>
</Grid>
<Grid item xs={12}>
<br />
<HelpBox
title={"Replication"}
iconComponent={<BucketsIcon />}

View File

@@ -14,7 +14,7 @@
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
import React from "react";
import React, { Fragment, useState } from "react";
import { connect } from "react-redux";
import { DialogContentText } from "@mui/material";
import { setErrorSnackMessage } from "../../../../actions";
@@ -22,12 +22,16 @@ import { ErrorResponseHandler } from "../../../../common/types";
import useApi from "../../Common/Hooks/useApi";
import ConfirmDialog from "../../Common/ModalWrapper/ConfirmDialog";
import { ConfirmDeleteIcon } from "../../../../icons";
import Grid from "@mui/material/Grid";
import InputBoxWrapper from "../../Common/FormComponents/InputBoxWrapper/InputBoxWrapper";
interface IDeleteReplicationProps {
closeDeleteModalAndRefresh: (refresh: boolean) => void;
deleteOpen: boolean;
selectedBucket: string;
ruleToDelete: string;
ruleToDelete?: string;
remainingRules: number;
deleteAllRules?: boolean;
setErrorSnackMessage: typeof setErrorSnackMessage;
}
@@ -36,8 +40,12 @@ const DeleteReplicationRule = ({
deleteOpen,
selectedBucket,
ruleToDelete,
remainingRules,
setErrorSnackMessage,
deleteAllRules = false,
}: IDeleteReplicationProps) => {
const [confirmationText, setConfirmationText] = useState<string>("");
const onDelSuccess = () => closeDeleteModalAndRefresh(true);
const onDelError = (err: ErrorResponseHandler) => setErrorSnackMessage(err);
const onClose = () => closeDeleteModalAndRefresh(false);
@@ -49,27 +57,57 @@ const DeleteReplicationRule = ({
}
const onConfirmDelete = () => {
invokeDeleteApi(
"DELETE",
`/api/v1/buckets/${selectedBucket}/replication/${ruleToDelete}`
);
let url = `/api/v1/buckets/${selectedBucket}/replication/${ruleToDelete}`;
if (deleteAllRules || remainingRules === 1) {
url = `/api/v1/buckets/${selectedBucket}/delete-all-replication-rules`;
}
invokeDeleteApi("DELETE", url);
};
return (
<ConfirmDialog
title={`Delete Replication Rule`}
title={
deleteAllRules
? "Delete all Replication Rules"
: "Delete Replication Rule"
}
confirmText={"Delete"}
isOpen={deleteOpen}
titleIcon={<ConfirmDeleteIcon />}
isLoading={deleteLoading}
onConfirm={onConfirmDelete}
onClose={onClose}
confirmButtonProps={{
disabled: deleteAllRules && confirmationText !== "Yes, I am sure",
}}
confirmationContent={
<DialogContentText>
Are you sure you want to delete replication rule <b>{ruleToDelete}</b>
? <br />
Remember, at lease one rule must be present once replication has been
enabled
{deleteAllRules ? (
<Fragment>
Are you sure you want to remove all replication rules for bucket{" "}
<b>{selectedBucket}</b>?<br />
<br />
To continue please type <b>Yes, I am sure</b> in the box.
<Grid item xs={12}>
<InputBoxWrapper
id="retype-tenant"
name="retype-tenant"
onChange={(event: React.ChangeEvent<HTMLInputElement>) => {
setConfirmationText(event.target.value);
}}
label=""
value={confirmationText}
/>
</Grid>
</Fragment>
) : (
<Fragment>
Are you sure you want to delete replication rule{" "}
<b>{ruleToDelete}</b>?
</Fragment>
)}
</DialogContentText>
}
/>